Skip to content

Commit a0aab85

Browse files
committed
Fixes the issue with unit mismatch in adjustTransactionDuration
1 parent 268cd26 commit a0aab85

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

packages/core/src/js/tracing/onSpanEndUtils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ export const adjustTransactionDuration = (client: Client, span: Span, maxDuratio
3333
return;
3434
}
3535

36-
const diff = endTimestamp - startTimestamp;
37-
const isOutdatedTransaction = endTimestamp && (diff > maxDurationMs || diff < 0);
36+
const diff = endTimestamp - startTimestamp; // a diff in *seconds*
37+
const isOutdatedTransaction = endTimestamp && (diff > maxDurationMs / 1000 || diff < 0);
3838
if (isOutdatedTransaction) {
3939
span.setStatus({ code: SPAN_STATUS_ERROR, message: 'deadline_exceeded' });
4040
// TODO: check where was used, might be possible to delete

packages/core/src/js/tracing/span.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,12 @@ export const defaultIdleOptions: {
3636
* The max. time an idle span may run.
3737
* If this time is exceeded, the idle span will finish no matter what.
3838
*
39-
* @default 60_0000 (ms)
39+
* @default 60_000 (ms)
4040
*/
4141
idleTimeout: number;
4242
} = {
4343
idleTimeout: 1_000,
44-
finalTimeout: 60_0000,
44+
finalTimeout: 60_000,
4545
};
4646

4747
export const startIdleNavigationSpan = (

0 commit comments

Comments
 (0)