fix(feedback): Break circular dependency in ShakeToReportBug

Make startShakeListener accept an onShake callback instead of
importing showFeedbackWidget directly, breaking the cycle:
FeedbackWidgetManager -> ShakeToReportBug -> FeedbackWidgetManager.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: antonis

packages/core/src/js/feedback/FeedbackWidgetManager.tsx

@@ -135,7 +135,7 @@ const resetScreenshotButtonManager = (): void => {
 
 const showFeedbackOnShake = (): void => {
   lazyLoadAutoInjectFeedbackIntegration();
-  startShakeListener();
+  startShakeListener(showFeedbackWidget);
 };
 
 const hideFeedbackOnShake = (): void => {

packages/core/src/js/feedback/FeedbackWidgetProvider.tsx

@@ -16,6 +16,7 @@ import {
   SLIDE_ANIMATION_DURATION,
 } from './FeedbackWidgetManager';
 import { getFeedbackButtonOptions, getFeedbackOptions, getScreenshotButtonOptions, isShakeToReportEnabled } from './integration';
+import { showFeedbackWidget } from './FeedbackWidgetManager';
 import { ScreenshotButton } from './ScreenshotButton';
 import { startShakeListener, stopShakeListener } from './ShakeToReportBug';
 import { isModalSupported, isNativeDriverSupportedForColorAnimations } from './utils';
@@ -101,7 +102,7 @@ export class FeedbackWidgetProvider extends React.Component<FeedbackWidgetProvid
     });
 
     if (isShakeToReportEnabled()) {
-      startShakeListener();
+      startShakeListener(showFeedbackWidget);
     }
   }
 

packages/core/src/js/feedback/ShakeToReportBug.ts

@@ -3,7 +3,6 @@ import type { EmitterSubscription, NativeModule } from 'react-native';
 import { NativeEventEmitter } from 'react-native';
 import { getRNSentryModule } from '../wrapper';
 import { isWeb } from '../utils/environment';
-import { showFeedbackWidget } from './FeedbackWidgetManager';
 
 export const OnShakeEventName = 'rn_sentry_on_shake';
 
@@ -19,13 +18,16 @@ const defaultEmitterFactory: EmitterFactory = nativeModule =>
   new NativeEventEmitter(nativeModule);
 
 /**
- * Starts listening for device shake events and shows the feedback widget when a shake is detected.
+ * Starts listening for device shake events and invokes the provided callback when a shake is detected.
  *
  * This starts native shake detection:
  * - iOS: Uses UIKit's motion event detection (no permissions required)
  * - Android: Uses the accelerometer sensor (no permissions required)
  */
-export function startShakeListener(createEmitter: EmitterFactory = defaultEmitterFactory): void {
+export function startShakeListener(
+  onShake: () => void,
+  createEmitter: EmitterFactory = defaultEmitterFactory,
+): void {
   if (_shakeSubscription) {
     debug.log('Shake listener is already active.');
     return;
@@ -44,8 +46,8 @@ export function startShakeListener(createEmitter: EmitterFactory = defaultEmitte
 
   const emitter = createEmitter(nativeModule);
   _shakeSubscription = emitter.addListener(OnShakeEventName, () => {
-    debug.log('Shake detected, showing feedback widget.');
-    showFeedbackWidget();
+    debug.log('Shake detected.');
+    onShake();
   });
 }
 

packages/core/test/feedback/ShakeToReportBug.test.tsx

@@ -85,24 +85,24 @@ describe('ShakeToReportBug', () => {
   describe('startShakeListener / stopShakeListener', () => {
     it('starts listening for shake events', () => {
       const actual = jest.requireActual('../../src/js/feedback/ShakeToReportBug');
-      actual.startShakeListener(mockEmitterFactory);
+      actual.startShakeListener(jest.fn(), mockEmitterFactory);
 
       expect(actual.isShakeListenerActive()).toBe(true);
       expect(mockEmitterFactory).toHaveBeenCalledTimes(1);
     });
 
     it('does not start a second listener if already active', () => {
       const actual = jest.requireActual('../../src/js/feedback/ShakeToReportBug');
-      actual.startShakeListener(mockEmitterFactory);
-      actual.startShakeListener(mockEmitterFactory);
+      actual.startShakeListener(jest.fn(), mockEmitterFactory);
+      actual.startShakeListener(jest.fn(), mockEmitterFactory);
 
       expect(actual.isShakeListenerActive()).toBe(true);
       expect(mockEmitterFactory).toHaveBeenCalledTimes(1);
     });
 
     it('stops listening for shake events', () => {
       const actual = jest.requireActual('../../src/js/feedback/ShakeToReportBug');
-      actual.startShakeListener(mockEmitterFactory);
+      actual.startShakeListener(jest.fn(), mockEmitterFactory);
       actual.stopShakeListener();
 
       expect(actual.isShakeListenerActive()).toBe(false);
@@ -114,27 +114,14 @@ describe('ShakeToReportBug', () => {
       expect(() => actual.stopShakeListener()).not.toThrow();
     });
 
-    it('calls showFeedbackWidget when shake event is received', async () => {
-      mockedIsModalSupported.mockReturnValue(true);
-
-      const { getByTestId, queryByTestId } = render(
-        <FeedbackWidgetProvider>
-          <Text>App Components</Text>
-        </FeedbackWidgetProvider>,
-      );
-
+    it('invokes onShake callback when shake event is received', () => {
       const actual = jest.requireActual('../../src/js/feedback/ShakeToReportBug');
-      actual.startShakeListener(mockEmitterFactory);
+      const onShake = jest.fn();
+      actual.startShakeListener(onShake, mockEmitterFactory);
 
-      expect(queryByTestId('feedback-form-modal')).toBeNull();
+      mockShakeCallback?.();
 
-      await act(async () => {
-        mockShakeCallback?.();
-      });
-
-      await waitFor(() => {
-        expect(getByTestId('feedback-form-modal')).toBeTruthy();
-      });
+      expect(onShake).toHaveBeenCalledTimes(1);
     });
   });