Skip to content

ref: Rename _timestamp to _end_timestamp #6235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sentrivana merged 7 commits into from
May 7, 2026

fix

ea130a0
Select commit
Loading
Failed to load commit list.
Merged

ref: Rename _timestamp to _end_timestamp #6235

fix
ea130a0
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: find-bugs completed May 7, 2026 in 2m 53s

1 issue

find-bugs: Found 1 issue (1 high)

High

__slots__ still declares `_timestamp`, breaking every StreamedSpan instantiation after rename - `sentry_sdk/traces.py:294`

The rename of _timestamp to _end_timestamp was not propagated to StreamedSpan.__slots__ (sentry_sdk/traces.py line 247). Because the class defines __slots__, assigning self._end_timestamp = None in __init__ (line 294) raises AttributeError: 'StreamedSpan' object has no attribute '_end_timestamp'. Every attempt to create a StreamedSpan will fail at construction time, breaking all span streaming functionality.

Duration: 1m 29s · Tokens: 364.2k in / 6.0k out · Cost: $1.21 (+verification: $0.58)

Annotations

Check failure on line 294 in sentry_sdk/traces.py

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: find-bugs

__slots__ still declares `_timestamp`, breaking every StreamedSpan instantiation after rename 

The rename of `_timestamp` to `_end_timestamp` was not propagated to `StreamedSpan.__slots__` (sentry_sdk/traces.py line 247). Because the class defines `__slots__`, assigning `self._end_timestamp = None` in `__init__` (line 294) raises `AttributeError: 'StreamedSpan' object has no attribute '_end_timestamp'`. Every attempt to create a StreamedSpan will fail at construction time, breaking all span streaming functionality.
View more details on @sentry/warden