Skip to content

merge master

bc1f32d
Select commit
Loading
Failed to load commit list.
Merged

feat(stdlib): Support span streaming #6154

merge master
bc1f32d
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: code-review completed Apr 29, 2026 in 45s

1 issue

code-review: Found 1 issue (1 low)

Low

ApproxDict({}) assertion is a no-op and weakens init span coverage - `tests/integrations/stdlib/test_subprocess.py:165`

On line 165, subprocess_init_span.get("attributes", {}) == data compares against data = ApproxDict({}). Per ApproxDict's __eq__ (tests/conftest.py), an empty ApproxDict matches any dict because the all(...) over zero items is trivially True. As a result, this assertion validates nothing about the init span's attributes and silently passes regardless of what attributes are present (or absent). The test loses coverage of the init span's expected attribute payload in the streaming path.


Duration: 44.7s · Tokens: 278.8k in / 3.1k out · Cost: $2.44