Skip to content

Commit bb23e2b

Browse files
committed
update some of the tests
1 parent c9c2ded commit bb23e2b

7 files changed

Lines changed: 48 additions & 5 deletions

File tree

sentry_sdk/integrations/stdlib.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,7 @@ def add_python_runtime_context(
5858
is_span_streaming_enabled = has_span_streaming_enabled(client.options)
5959
if is_span_streaming_enabled:
6060
current_scope = get_current_scope()
61-
segment = (
62-
current_scope.streamed_span._segment
63-
if current_scope.streamed_span
64-
else None
65-
)
61+
segment = getattr(current_scope.streamed_span, "_segment", None)
6662

6763
if segment:
6864
segment.set_attribute(

tests/integrations/logging/test_logging.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
import logging
2+
import platform
3+
import sys
24
import warnings
35

46
import pytest
@@ -537,6 +539,8 @@ def test_logger_with_all_attributes(sentry_init, capture_items):
537539
"logger.name": "test-logger",
538540
"sentry.origin": "auto.log.stdlib",
539541
"sentry.message.template": "log #%d",
542+
"process.runtime.name": platform.python_implementation(),
543+
"process.runtime.version": f"{sys.version_info.major}.{sys.version_info.minor}.{sys.version_info.micro}",
540544
"sentry.message.parameter.0": 1,
541545
"sentry.environment": "production",
542546
"sentry.sdk.version": VERSION,

tests/integrations/loguru/test_loguru.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1+
import platform
12
import re
3+
import sys
24
from unittest.mock import MagicMock, patch
35

46
import pytest
@@ -466,6 +468,8 @@ def test_logger_with_all_attributes(
466468
"logger.name": "tests.integrations.loguru.test_loguru",
467469
"sentry.origin": "auto.log.loguru",
468470
"sentry.environment": "production",
471+
"process.runtime.name": platform.python_implementation(),
472+
"process.runtime.version": f"{sys.version_info.major}.{sys.version_info.minor}.{sys.version_info.micro}",
469473
"sentry.sdk.version": VERSION,
470474
"sentry.severity_number": 13,
471475
"sentry.severity_text": "warn",

tests/integrations/openai/test_openai.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
import json
2+
import platform
3+
import sys
24

35
import pytest
46

@@ -4975,6 +4977,8 @@ async def test_ai_client_span_streaming_responses_async_api(
49754977
"sentry.environment": "production",
49764978
"sentry.op": "gen_ai.responses",
49774979
"sentry.origin": "auto.ai.openai",
4980+
"process.runtime.name": platform.python_implementation(),
4981+
"process.runtime.version": f"{sys.version_info.major}.{sys.version_info.minor}.{sys.version_info.micro}",
49784982
"sentry.release": mock.ANY,
49794983
"sentry.sdk.name": "sentry.python",
49804984
"sentry.sdk.version": mock.ANY,

tests/test_logs.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import logging
22
import os
3+
import platform
34
import sys
45
import time
56
from unittest import mock
@@ -495,6 +496,14 @@ def test_transport_format(sentry_init, capture_envelopes):
495496
"type": "integer",
496497
"value": 13,
497498
},
499+
"process.runtime.name": {
500+
"type": "string",
501+
"value": platform.python_implementation(),
502+
},
503+
"process.runtime.version": {
504+
"type": "string",
505+
"value": f"{sys.version_info.major}.{sys.version_info.minor}.{sys.version_info.micro}",
506+
},
498507
"sentry.severity_text": {
499508
"type": "string",
500509
"value": "warn",
@@ -574,6 +583,14 @@ def record_lost_event(reason, data_category=None, item=None, *, quantity=1):
574583
"type": "integer",
575584
"value": 9,
576585
},
586+
"process.runtime.name": {
587+
"type": "string",
588+
"value": platform.python_implementation(),
589+
},
590+
"process.runtime.version": {
591+
"type": "string",
592+
"value": f"{sys.version_info.major}.{sys.version_info.minor}.{sys.version_info.micro}",
593+
},
577594
"sentry.severity_text": {
578595
"type": "string",
579596
"value": "info",

tests/test_metrics.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import os
2+
import platform
23
import sys
34
from unittest import mock
45

@@ -284,6 +285,14 @@ def test_transport_format(sentry_init, capture_envelopes):
284285
"type": "string",
285286
"value": "1.0.0",
286287
},
288+
"process.runtime.name": {
289+
"type": "string",
290+
"value": platform.python_implementation(),
291+
},
292+
"process.runtime.version": {
293+
"type": "string",
294+
"value": f"{sys.version_info.major}.{sys.version_info.minor}.{sys.version_info.micro}",
295+
},
287296
"sentry.sdk.name": {
288297
"type": "string",
289298
"value": mock.ANY,

tests/tracing/test_span_streaming.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import asyncio
2+
import platform
23
import re
34
import sys
45
import time
@@ -1722,4 +1723,12 @@ def test_default_attributes(sentry_init, capture_envelopes):
17221723
"sentry.dist": {"value": "1.0", "type": "string"},
17231724
"sentry.origin": {"value": "manual", "type": "string"},
17241725
"sentry.sdk.integrations": {"value": mock.ANY, "type": "array"},
1726+
"process.runtime.name": {
1727+
"type": "string",
1728+
"value": platform.python_implementation(),
1729+
},
1730+
"process.runtime.version": {
1731+
"type": "string",
1732+
"value": f"{sys.version_info.major}.{sys.version_info.minor}.{sys.version_info.micro}",
1733+
},
17251734
}

0 commit comments

Comments
 (0)