Skip to content

Commit 42aca21

Browse files
update
1 parent a58e42d commit 42aca21

4 files changed

Lines changed: 16 additions & 6 deletions

File tree

sentry_sdk/integrations/litestar.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@ def __init__(
9292
mechanism_type="asgi",
9393
span_origin=span_origin,
9494
asgi_version=3,
95+
# https://github.com/litestar-org/litestar/issues/2077
96+
path_includes_root_path=False,
9597
)
9698

9799
def _capture_request_exception(self, exc: Exception) -> None:

sentry_sdk/integrations/starlite.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,8 @@ def __init__(
7777
mechanism_type="asgi",
7878
span_origin=span_origin,
7979
asgi_version=3,
80+
# https://github.com/litestar-org/litestar/issues/2077
81+
path_includes_root_path=False,
8082
)
8183

8284

tests/integrations/litestar/test_litestar.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -830,13 +830,16 @@ def test_request_url(sentry_init, capture_events, capture_items, span_streaming)
830830
sentry_init(
831831
traces_sample_rate=1.0,
832832
integrations=[LitestarIntegration()],
833+
send_default_pii=True,
833834
_experiments={
834835
"trace_lifecycle": "stream" if span_streaming else "static",
835836
},
836837
)
837838

838839
litestar_app = litestar_app_factory()
839-
client = TestClient(litestar_app, root_path="/root")
840+
client = TestClient(
841+
litestar_app, base_url="http://testserver.local", root_path="/root"
842+
)
840843

841844
if span_streaming:
842845
items = capture_items("span")
@@ -852,12 +855,12 @@ def test_request_url(sentry_init, capture_events, capture_items, span_streaming)
852855
if span["attributes"].get("sentry.op") == "http.server"
853856
)
854857
assert server_span["attributes"]["url.full"] == (
855-
"http://testserver/root/nomessage"
858+
"http://testserver.local/root/nomessage"
856859
)
857860
else:
858861
events = capture_events()
859862

860863
client.get("/root/nomessage")
861864

862865
(event,) = events
863-
assert event["request"]["url"] == "http://testserver/root/nomessage"
866+
assert event["request"]["url"] == "http://testserver.local/root/nomessage"

tests/integrations/starlite/test_starlite.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -586,13 +586,16 @@ def test_request_url(sentry_init, capture_events, capture_items, span_streaming)
586586
sentry_init(
587587
traces_sample_rate=1.0,
588588
integrations=[StarliteIntegration()],
589+
send_default_pii=True,
589590
_experiments={
590591
"trace_lifecycle": "stream" if span_streaming else "static",
591592
},
592593
)
593594

594595
starlite_app = starlite_app_factory()
595-
client = TestClient(starlite_app, root_path="/root")
596+
client = TestClient(
597+
starlite_app, base_url="http://testserver.local", root_path="/root"
598+
)
596599

597600
if span_streaming:
598601
items = capture_items("span")
@@ -608,12 +611,12 @@ def test_request_url(sentry_init, capture_events, capture_items, span_streaming)
608611
if span["attributes"].get("sentry.op") == "http.server"
609612
)
610613
assert server_span["attributes"]["url.full"] == (
611-
"http://testserver/root/nomessage"
614+
"http://testserver.local/root/nomessage"
612615
)
613616
else:
614617
events = capture_events()
615618

616619
client.get("/nomessage")
617620

618621
(event,) = events
619-
assert event["request"]["url"] == "http://testserver/root/nomessage"
622+
assert event["request"]["url"] == "http://testserver.local/root/nomessage"

0 commit comments

Comments
 (0)