Skip to content

Commit e041a2b

Browse files
Copilotvaind
andauthored
test: Fix flaky test_external_crash_reporter_http when running with kcov (#1419)
* Initial plan * Fix crash test assertions to handle kcov's exit code behavior Co-authored-by: vaind <[email protected]> * Skip entire crash tests when running with kcov instead of conditional assertions Co-authored-by: vaind <[email protected]> * Only skip test_external_crash_reporter_http when running with kcov Co-authored-by: vaind <[email protected]> * Update tests/test_integration_http.py * Update tests/test_integration_http.py * Update tests/test_integration_http.py --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: vaind <[email protected]>
1 parent 7d3a752 commit e041a2b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

tests/test_integration_http.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
assert_attachment_view_hierarchy,
4040
assert_logs,
4141
)
42-
from .conditions import has_http, has_breakpad, has_files
42+
from .conditions import has_http, has_breakpad, has_files, is_kcov
4343

4444
pytestmark = pytest.mark.skipif(not has_http, reason="tests need http")
4545

@@ -206,6 +206,7 @@ def test_user_report_http(cmake, httpserver):
206206
assert_user_report(envelope)
207207

208208

209+
@pytest.mark.skipif(is_kcov, reason="kcov exits with 0 even when the process crashes")
209210
@pytest.mark.parametrize(
210211
"build_args",
211212
[

0 commit comments

Comments
 (0)