From 98bda52112827a4e5a47c7316250e4d52ed037b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kamil=20Og=C3=B3rek?= Date: Tue, 17 Oct 2017 14:13:43 +0200 Subject: [PATCH] ci: Remove build artefacts after test:size and update CONTRIB docs --- CONTRIBUTING.md | 6 ++++++ package.json | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c5d7fdc404ac..d5a305e2be98 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -68,6 +68,12 @@ $ npm run test:karma:integration Then visit: http://localhost:9876/debug.html +Keep in mind that in order for in-browser tests to work correctly, they need to be bundled first: + +```bash +$ grunt build.test +``` + If you want to make sure that your changes will fit in our 10kB budget: ```bash diff --git a/package.json b/package.json index c2b477afae44..b0e5e934b295 100644 --- a/package.json +++ b/package.json @@ -19,7 +19,7 @@ "lint": "eslint .", "precommit": "lint-staged", "publish": "npm run test && grunt publish", - "test": "npm run lint && npm run test:size && grunt build.test && npm run test:unit && npm run test:integration && npm run test:typescript", + "test": "npm run lint && grunt build.test && npm run test:unit && npm run test:integration && npm run test:typescript", "test:karma:unit": "karma start karma.unit.config.js", "test:karma:integration": "karma start karma.integration.config.js ", "test:karma:sauce": "karma start karma.sauce.config.js ", @@ -27,7 +27,7 @@ "test:integration": "npm run test:karma:integration -- --single-run", "test:typescript": "tsc --noEmit --noImplicitAny typescript/raven-tests.ts", "test:ci": "npm run lint && grunt test:ci && npm run test:karma:sauce", - "test:size": "grunt dist && bundlesize" + "test:size": "grunt dist && bundlesize && git checkout -- dist/" }, "devDependencies": { "bluebird": "^3.4.1",