Skip to content

Commit e6bd7a3

Browse files
committed
address cursor
1 parent 367be5f commit e6bd7a3

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

sentry-jul/src/test/kotlin/io/sentry/jul/SentryHandlerTest.kt

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class SentryHandlerTest {
3535
val configureWithLogManager: Boolean = false,
3636
val transport: ITransport = mock(),
3737
contextTags: List<String>? = null,
38-
printfStyle: Boolean = true,
38+
printfStyle: Boolean? = null,
3939
) {
4040
var logger: Logger
4141
var handler: SentryHandler
@@ -50,7 +50,9 @@ class SentryHandlerTest {
5050
handler.setMinimumBreadcrumbLevel(minimumBreadcrumbLevel)
5151
handler.setMinimumEventLevel(minimumEventLevel)
5252
handler.setMinimumLevel(minimumLevel)
53-
handler.setPrintfStyle(printfStyle)
53+
if (printfStyle == true) {
54+
handler.setPrintfStyle(printfStyle)
55+
}
5456
handler.level = Level.ALL
5557
logger.handlers.forEach { logger.removeHandler(it) }
5658
logger.addHandler(handler)
@@ -534,18 +536,18 @@ class SentryHandlerTest {
534536

535537
@Test
536538
fun `sets template on log when logging message with parameters and formatting fails`() {
537-
fixture = Fixture(minimumLevel = Level.SEVERE)
538-
fixture.logger.log(Level.SEVERE, "testing message {0} {1}", arrayOf(1))
539+
fixture = Fixture(minimumLevel = Level.SEVERE, printfStyle = true)
540+
fixture.logger.log(Level.SEVERE, "testing message %d %d", arrayOf(1))
539541

540542
Sentry.flush(1000)
541543

542544
verify(fixture.transport)
543545
.send(
544546
checkLogs { logs ->
545547
val log = logs.items.first()
546-
assertEquals("testing message {0} {1}", log.body)
548+
assertEquals("testing message %d %d", log.body)
547549
assertEquals(
548-
"testing message {0} {1}",
550+
"testing message %d %d",
549551
log.attributes?.get("sentry.message.template")?.value,
550552
)
551553
assertEquals(1, log.attributes?.get("sentry.message.parameter.0")?.value)

0 commit comments

Comments
 (0)