Skip to content

Commit a033be2

Browse files
runningcodeclaude
andcommitted
fix(build): Remove testBuildType mechanism from UI test modules
The debug and release build types were configured identically in both uitest modules (same minification, proguard rules, signing). Disable the debug variant unconditionally, hardcode testBuildType to release, and combine the now-simplified Gradle invocations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent eb95ded commit a033be2

6 files changed

Lines changed: 14 additions & 33 deletions

File tree

.github/workflows/agp-matrix.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ jobs:
9090
disable-spellchecker: true
9191
emulator-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
9292
disk-size: 4096M
93-
script: ./gradlew sentry-android-integration-tests:sentry-uitest-android:connectedReleaseAndroidTest -DtestBuildType=release -Denvironment=github --daemon
93+
script: ./gradlew sentry-android-integration-tests:sentry-uitest-android:connectedReleaseAndroidTest -Denvironment=github --daemon
9494

9595
- name: Upload test results
9696
if: always()

AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ make systemTest
7676
```bash
7777
# Assemble Android test APKs
7878
./gradlew :sentry-android-integration-tests:sentry-uitest-android:assembleRelease
79-
./gradlew :sentry-android-integration-tests:sentry-uitest-android:assembleAndroidTest -DtestBuildType=release
79+
./gradlew :sentry-android-integration-tests:sentry-uitest-android:assembleAndroidTest
8080

8181
# Run critical UI tests
8282
./scripts/test-ui-critical.sh

Makefile

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,11 @@ api:
3737

3838
# Assemble release and Android test apk of the uitest-android-benchmark module
3939
assembleBenchmarkTestRelease:
40-
./gradlew :sentry-android-integration-tests:sentry-uitest-android-benchmark:assembleRelease
41-
./gradlew :sentry-android-integration-tests:sentry-uitest-android-benchmark:assembleAndroidTest -DtestBuildType=release
40+
./gradlew :sentry-android-integration-tests:sentry-uitest-android-benchmark:assembleRelease :sentry-android-integration-tests:sentry-uitest-android-benchmark:assembleAndroidTest
4241

4342
# Assemble release and Android test apk of the uitest-android module
4443
assembleUiTestRelease:
45-
./gradlew :sentry-android-integration-tests:sentry-uitest-android:assembleRelease
46-
./gradlew :sentry-android-integration-tests:sentry-uitest-android:assembleAndroidTest -DtestBuildType=release
44+
./gradlew :sentry-android-integration-tests:sentry-uitest-android:assembleRelease :sentry-android-integration-tests:sentry-uitest-android:assembleAndroidTest
4745

4846
# Assemble release of the uitest-android-critical module
4947
assembleUiTestCriticalRelease:

sentry-android-integration-tests/sentry-uitest-android-benchmark/build.gradle.kts

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -46,21 +46,9 @@ android {
4646
}
4747
}
4848

49-
testBuildType = System.getProperty("testBuildType", "debug")
49+
testBuildType = "release"
5050

5151
buildTypes {
52-
getByName("debug") {
53-
isMinifyEnabled = true
54-
signingConfig = signingConfigs.getByName("debug")
55-
proguardFiles(
56-
getDefaultProguardFile("proguard-android-optimize.txt"),
57-
"benchmark-proguard-rules.pro",
58-
)
59-
testProguardFiles(
60-
getDefaultProguardFile("proguard-android-optimize.txt"),
61-
"benchmark-proguard-rules.pro",
62-
)
63-
}
6452
getByName("release") {
6553
isMinifyEnabled = true
6654
isShrinkResources = true
@@ -89,7 +77,9 @@ android {
8977
}
9078

9179
androidComponents.beforeVariants {
92-
it.enable = !Config.Android.shouldSkipDebugVariant(it.buildType)
80+
if (it.buildType == "debug") {
81+
it.enable = false
82+
}
9383
}
9484
}
9585

sentry-android-integration-tests/sentry-uitest-android/README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,12 @@ You can run benchmark tests only with `./gradlew :sentry-android-integration-tes
1414
To run on saucelabs execute following commands (need also `SAUCE_USERNAME` and `SAUCE_ACCESS_KEY` environment variables):
1515
For Benchmarks:
1616
```
17-
./gradlew :sentry-android-integration-tests:sentry-uitest-android-benchmark:assembleRelease
18-
./gradlew :sentry-android-integration-tests:sentry-uitest-android-benchmark:assembleAndroidTest -DtestBuildType=release
17+
./gradlew :sentry-android-integration-tests:sentry-uitest-android-benchmark:assembleRelease :sentry-android-integration-tests:sentry-uitest-android-benchmark:assembleAndroidTest
1918
saucectl run -c .sauce/sentry-uitest-android-benchmark.yml
2019
```
2120
For End 2 End:
2221
```
23-
./gradlew :sentry-android-integration-tests:sentry-uitest-android:assembleRelease
24-
./gradlew :sentry-android-integration-tests:sentry-uitest-android:assembleAndroidTest -DtestBuildType=release
22+
./gradlew :sentry-android-integration-tests:sentry-uitest-android:assembleRelease :sentry-android-integration-tests:sentry-uitest-android:assembleAndroidTest
2523
saucectl run -c .sauce/sentry-uitest-android-end2end.yml
2624
```
2725

sentry-android-integration-tests/sentry-uitest-android/build.gradle.kts

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -51,18 +51,11 @@ android {
5151
}
5252
}
5353

54-
testBuildType = System.getProperty("testBuildType", "debug")
54+
testBuildType = "release"
5555

5656
buildTypes {
57-
getByName("debug") {
58-
isMinifyEnabled = true
59-
signingConfig = signingConfigs.getByName("debug")
60-
proguardFiles(getDefaultProguardFile("proguard-android-optimize.txt"), "proguard-rules.pro")
61-
testProguardFiles("proguard-rules.pro")
62-
}
6357
getByName("release") {
6458
isMinifyEnabled = true
65-
isShrinkResources = false
6659
proguardFiles(getDefaultProguardFile("proguard-android-optimize.txt"), "proguard-rules.pro")
6760
signingConfig = signingConfigs.getByName("debug") // to be able to run release mode
6861
testProguardFiles("proguard-rules.pro")
@@ -82,7 +75,9 @@ android {
8275
}
8376

8477
androidComponents.beforeVariants {
85-
it.enable = !Config.Android.shouldSkipDebugVariant(it.buildType)
78+
if (it.buildType == "debug") {
79+
it.enable = false
80+
}
8681
}
8782
}
8883

0 commit comments

Comments
 (0)