Skip to content

Commit 4bc868b

Browse files
authored
fix(replay): Expand fix for crash on devices to all Unisoc/Spreadtrum chipsets (#4510)
* fix(replay): Expand fix for crash on devices to all Unisoc/Spreadtrum chipsets * pr id
1 parent 6cea621 commit 4bc868b

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
### Fixes
66

77
- No longer send out empty log envelopes ([#4497](https://github.com/getsentry/sentry-java/pull/4497))
8+
- Session Replay: Expand fix for crash on devices to all Unisoc/Spreadtrum chipsets ([#4510](https://github.com/getsentry/sentry-java/pull/4510))
89

910
### Dependencies
1011

sentry-android-replay/src/main/java/io/sentry/android/replay/video/SimpleVideoEncoder.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -161,15 +161,15 @@ internal class SimpleVideoEncoder(
161161
* ---
162162
* Same for Motorola devices.
163163
* ---
164-
* As for the T606, it's a Spreadtrum/Unisoc chipset and can be spread across various
165-
* devices, so we have to check the SOC_MODEL property, as the manufacturer name might have
166-
* changed.
164+
* As for the Spreadtrum/Unisoc chipset, it can be spread across various devices, so we have
165+
* to check the SOC_MANUFACTURER property, as the manufacturer name might have changed.
167166
* https://github.com/getsentry/sentry-android-gradle-plugin/issues/861#issuecomment-2867021256
168167
*/
169168
val canvas = if (
170169
Build.MANUFACTURER.contains("xiaomi", ignoreCase = true) ||
171170
Build.MANUFACTURER.contains("motorola", ignoreCase = true) ||
172-
SystemProperties.get(SystemProperties.Property.SOC_MODEL).equals("T606", ignoreCase = true)
171+
SystemProperties.get(SystemProperties.Property.SOC_MANUFACTURER).equals("spreadtrum", ignoreCase = true) ||
172+
SystemProperties.get(SystemProperties.Property.SOC_MANUFACTURER).equals("unisoc", ignoreCase = true)
173173
) {
174174
surface?.lockCanvas(null)
175175
} else {

0 commit comments

Comments
 (0)