Merge pull request #5600 from getsentry/perf/sdk-overhead-reduction-reflection-visiting

perf(core): [SDK Overhead Reduction 9] Lazily allocate reflection serializer state

Author: adinauer

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 ### Internal
 
+- Reduce JSON serialization overhead by allocating reflection cycle-tracking state only when reflection serialization is used. ([#5600](https://github.com/getsentry/sentry-java/pull/5600))
 - Reduce context serialization overhead by sorting key snapshots with arrays instead of temporary lists. ([#5599](https://github.com/getsentry/sentry-java/pull/5599))
 - Reduce breadcrumb allocation overhead by creating the `Breadcrumb` data map only when data is added. ([#5598](https://github.com/getsentry/sentry-java/pull/5598))
 - Reduce JSON serialization overhead by lowering the initial `JsonWriter` nesting stack size while preserving on-demand growth. ([#5591](https://github.com/getsentry/sentry-java/pull/5591))

sentry/src/main/java/io/sentry/JsonReflectionObjectSerializer.java

@@ -30,7 +30,7 @@
 @ApiStatus.Internal
 public final class JsonReflectionObjectSerializer {
 
-  private final Set<Object> visiting = new HashSet<>();
+  private @Nullable Set<Object> visiting;
   private final int maxDepth;
 
   JsonReflectionObjectSerializer(int maxDepth) {
@@ -69,6 +69,7 @@ public final class JsonReflectionObjectSerializer {
     } else if (object.getClass().isEnum()) {
       return object.toString();
     } else {
+      final Set<Object> visiting = getVisiting();
       if (visiting.contains(object)) {
         logger.log(SentryLevel.INFO, "Cyclic reference detected. Calling toString() on object.");
         return object.toString();
@@ -135,6 +136,13 @@ public final class JsonReflectionObjectSerializer {
 
   // Helper
 
+  private @NotNull Set<Object> getVisiting() {
+    if (visiting == null) {
+      visiting = new HashSet<>();
+    }
+    return visiting;
+  }
+
   private @NotNull List<Object> list(@NotNull Object[] objectArray, @NotNull ILogger logger)
       throws Exception {
     List<Object> list = new ArrayList<>();