Skip to content

Commit 210b4ee

Browse files
buenaflorclaude
andcommitted
test(extend-app-start): Drop redundant getExtendedAppStartSpan finished test
After getExtendedAppStartSpan switched to getFinishDate(), the "after the span finished" case exercises the same branch as the reentrancy test (finishDate set -> NoOp); the isFinished stub was inert. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 33a6aa0 commit 210b4ee

1 file changed

Lines changed: 0 additions & 11 deletions

File tree

sentry-android-core/src/test/java/io/sentry/android/core/AppStartExtensionTest.kt

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -233,17 +233,6 @@ class AppStartExtensionTest {
233233
assertSame(NoOpSpan.getInstance(), ext.extendedAppStartSpan)
234234
}
235235

236-
@Test
237-
fun `getExtendedAppStartSpan returns NoOpSpan after the span finished`() {
238-
val ext = extension(windowOpen = true)
239-
val span = mock<ISpan>()
240-
whenever(span.isFinished).thenReturn(true)
241-
whenever(span.finishDate).thenReturn(SentryNanotimeDate())
242-
ext.registerHandOver(span = span)
243-
ext.extendAppStart()
244-
assertSame(NoOpSpan.getInstance(), ext.extendedAppStartSpan)
245-
}
246-
247236
@Test
248237
fun `getExtendedAppStartSpan returns NoOpSpan once the finish date is set even if still unfinished`() {
249238
// Same waitForChildren reentrancy as getExtendedEndTime: the finish timestamp is set before the

0 commit comments

Comments
 (0)