Skip to content

Commit a330b16

Browse files
committed
fix ups
wip
1 parent e53e272 commit a330b16

File tree

5 files changed

+49
-55
lines changed

5 files changed

+49
-55
lines changed

lib/sentry/config.ex

+29-29
Original file line numberDiff line numberDiff line change
@@ -315,36 +315,36 @@ defmodule Sentry.Config do
315315
connections to keep in the pool. Only applied if `:client` is set to
316316
`Sentry.FinchClient`.
317317
"""
318-
],
319-
hackney_opts: [
320-
type: :keyword_list,
321-
deprecated: "Use Finch instead as default client.",
322-
default: [pool: :sentry_pool],
323-
doc: """
324-
Options to be passed to `hackney`. Only
325-
applied if `:client` is set to `Sentry.HackneyClient`.
326-
"""
327-
],
328-
hackney_pool_timeout: [
329-
type: :timeout,
330-
deprecated: "Use Finch instead as default client.",
331-
default: 5000,
332-
doc: """
333-
The maximum time to wait for a
334-
connection to become available. Only applied if `:client` is set to
335-
`Sentry.HackneyClient`.
336-
"""
337-
],
338-
hackney_pool_max_connections: [
339-
type: :pos_integer,
340-
deprecated: "Use Finch instead as default client.",
341-
default: 50,
342-
doc: """
343-
The maximum number of
344-
connections to keep in the pool. Only applied if `:client` is set to
345-
`Sentry.HackneyClient`.
346-
"""
347318
]
319+
# hackney_opts: [
320+
# type: :keyword_list,
321+
# deprecated: "Use Finch instead as default client.",
322+
# default: [pool: :sentry_pool],
323+
# doc: """
324+
# Options to be passed to `hackney`. Only
325+
# applied if `:client` is set to `Sentry.HackneyClient`.
326+
# """
327+
# ],
328+
# hackney_pool_timeout: [
329+
# type: :timeout,
330+
# deprecated: "Use Finch instead as default client.",
331+
# default: 5000,
332+
# doc: """
333+
# The maximum time to wait for a
334+
# connection to become available. Only applied if `:client` is set to
335+
# `Sentry.HackneyClient`.
336+
# """
337+
# ],
338+
# hackney_pool_max_connections: [
339+
# type: :pos_integer,
340+
# deprecated: "Use Finch instead as default client.",
341+
# default: 50,
342+
# doc: """
343+
# The maximum number of
344+
# connections to keep in the pool. Only applied if `:client` is set to
345+
# `Sentry.HackneyClient`.
346+
# """
347+
# ]
348348
]
349349

350350
source_code_context_opts_schema = [

mix.exs

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ defmodule Sentry.Mixfile do
9494
{:nimble_ownership, "~> 0.3.0 or ~> 1.0"},
9595

9696
# Optional dependencies
97-
{:finch, "~> 0.18.0", optional: true},
97+
{:finch, "~> 0.19.0", optional: true},
9898
{:jason, "~> 1.1", optional: true},
9999
{:phoenix, "~> 1.6", optional: true},
100100
{:phoenix_live_view, "~> 0.20 or ~> 1.0", optional: true},

0 commit comments

Comments
 (0)