Skip to content

Commit ab21773

Browse files
authored
Prefix firebase remote config feature flags with firebase: (#3258)
1 parent 0a498b0 commit ab21773

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Changelog
22

3+
## Unreleased
4+
5+
### Enhancements
6+
7+
- Prefix firebase remote config feature flags with `firebase:` ([#3258](https://github.com/getsentry/sentry-dart/pull/3258))
8+
39
## 9.7.0-beta.5
410

511
### Dependencies

packages/firebase_remote_config/lib/src/sentry_firebase_remote_config_integration.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class SentryFirebaseRemoteConfigIntegration extends Integration<SentryOptions> {
3131
for (final updatedKey in updatedKeys) {
3232
final value = _firebaseRemoteConfig.getBoolOrNull(updatedKey);
3333
if (value != null) {
34-
await Sentry.addFeatureFlag(updatedKey, value);
34+
await Sentry.addFeatureFlag('firebase:$updatedKey', value);
3535
}
3636
}
3737
}

packages/firebase_remote_config/test/src/sentry_firebase_remote_config_integration_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ void main() {
8484

8585
expect(featureFlags, isNotNull);
8686
expect(featureFlags?.values.length, 1);
87-
expect(featureFlags?.values.first.flag, 'test');
87+
expect(featureFlags?.values.first.flag, 'firebase:test');
8888
expect(featureFlags?.values.first.result, isFalse);
8989
});
9090

@@ -105,7 +105,7 @@ void main() {
105105

106106
expect(featureFlags, isNotNull);
107107
expect(featureFlags?.values.length, 1);
108-
expect(featureFlags?.values.first.flag, 'test');
108+
expect(featureFlags?.values.first.flag, 'firebase:test');
109109
expect(featureFlags?.values.first.result, true);
110110
});
111111

0 commit comments

Comments
 (0)