Skip to content

Commit d7bb10c

Browse files
Fix: remove arm64e references (#402)
* Update Makefile to exclude arm64e architecture * Update Makefile * Update Makefile * use latest vm * Update Makefile * also hash makefile * refresh CI * add makefile key to job artifact * add changelog
1 parent 748a4e6 commit d7bb10c

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

.github/workflows/build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ jobs:
114114

115115
job_carthage_build:
116116
name: Build Carthage Dependencies
117-
runs-on: macos-15
117+
runs-on: macos-latest
118118
timeout-minutes: 30
119119
steps:
120120
- name: Check out current commit (${{ github.sha }})
@@ -124,7 +124,7 @@ jobs:
124124
id: cache_built_carthage
125125
with:
126126
path: ${{ env.CACHED_CARTHAGE_PATHS }}
127-
key: ${{ hashFiles('src/ios/Cartfile') }}
127+
key: ${{ hashFiles('src/ios/Cartfile', 'Makefile') }}
128128
- name: Install Carthage
129129
if: steps.cache_built_carthage.outputs.cache-hit != 'true'
130130
run: brew install carthage
@@ -159,7 +159,7 @@ jobs:
159159
uses: actions/cache@v4
160160
with:
161161
path: ${{ env.CACHED_CARTHAGE_PATHS }}
162-
key: ${{ hashFiles('src/ios/Cartfile') }}
162+
key: ${{ hashFiles('src/ios/Cartfile', 'Makefile') }}
163163
- name: Check that Carthage build exists
164164
run: test -d src/ios/Carthage || exit 1
165165
- name: Pack

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Changelog
22

3+
## Unreleased
4+
5+
### Fixes
6+
7+
- iOS app release due to inclusion of arm64e references ([#402](https://github.com/getsentry/sentry-cordova/pull/402))
8+
39
## 1.7.2
410

511
### Fixes

Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,5 @@
11
build:
2-
cd src/ios; carthage update --use-xcframeworks --platform ios; carthage build --use-xcframeworks --no-use-binaries --platform ios; rm -r Carthage/Build/SentrySwiftUI.xcframework
2+
cd src/ios && \
3+
carthage update --use-xcframeworks --platform ios && \
4+
EXCLUDED_ARCHS=arm64e carthage build --use-xcframeworks --no-use-binaries --platform ios && \
5+
rm -r Carthage/Build/SentrySwiftUI.xcframework

0 commit comments

Comments
 (0)