Skip to content

fix: Change type of sentry.dsc.project_id to string #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elramen merged 1 commit into from
May 22, 2026
+13 −13
Merged

fix: Change type of sentry.dsc.project_id to string #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions javascript/sentry-conventions/src/attributes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10248,21 +10248,21 @@ export type SENTRY_DSC_ENVIRONMENT_TYPE = string;
/**
* The ID of the project where the trace originated (i.e. the project of the SDK that started the trace). Propagated through the dynamic sampling context and set by Relay during ingestion. `sentry.dsc.project_id`
*
* Attribute Value Type: `number` {@link SENTRY_DSC_PROJECT_ID_TYPE}
* Attribute Value Type: `string` {@link SENTRY_DSC_PROJECT_ID_TYPE}
*
* Contains PII: false
*
* Attribute defined in OTEL: No
* Visibility: internal
*
* @example 12345
* @example "12345"
*/
export const SENTRY_DSC_PROJECT_ID = 'sentry.dsc.project_id';

/**
* Type for {@link SENTRY_DSC_PROJECT_ID} sentry.dsc.project_id
*/
export type SENTRY_DSC_PROJECT_ID_TYPE = number;
export type SENTRY_DSC_PROJECT_ID_TYPE = string;

// Path: model/attributes/sentry/sentry__dsc__public_key.json

Expand Down Expand Up @@ -13699,7 +13699,7 @@ export const ATTRIBUTE_TYPE: Record<string, AttributeType> = {
[SENTRY_DIST]: 'string',
[SENTRY_DOMAIN]: 'string',
[SENTRY_DSC_ENVIRONMENT]: 'string',
[SENTRY_DSC_PROJECT_ID]: 'integer',
[SENTRY_DSC_PROJECT_ID]: 'string',
[SENTRY_DSC_PUBLIC_KEY]: 'string',
[SENTRY_DSC_RELEASE]: 'string',
[SENTRY_DSC_SAMPLED]: 'boolean',
Expand Down Expand Up @@ -20785,13 +20785,13 @@ export const ATTRIBUTE_METADATA: Record<AttributeName, AttributeMetadata> = {
[SENTRY_DSC_PROJECT_ID]: {
brief:
'The ID of the project where the trace originated (i.e. the project of the SDK that started the trace). Propagated through the dynamic sampling context and set by Relay during ingestion.',
type: 'integer',
type: 'string',
pii: {
isPii: 'false',
},
isInOtel: false,
visibility: 'internal',
example: 12345,
example: '12345',
changelog: [{ version: '0.7.0', prs: [358], description: 'Add sentry.dsc.project_id as an attribute' }],
},
[SENTRY_DSC_PUBLIC_KEY]: {
Expand Down
4 changes: 2 additions & 2 deletions model/attributes/sentry/sentry__dsc__project_id.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"key": "sentry.dsc.project_id",
"brief": "The ID of the project where the trace originated (i.e. the project of the SDK that started the trace). Propagated through the dynamic sampling context and set by Relay during ingestion.",
"type": "integer",
"type": "string",
"pii": {
"key": "false"
},
"is_in_otel": false,
"example": 12345,
"example": "12345",
"visibility": "internal",
"changelog": [
{
Expand Down
10 changes: 5 additions & 5 deletions python/src/sentry_conventions/attributes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5987,11 +5987,11 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
SENTRY_DSC_PROJECT_ID: Literal["sentry.dsc.project_id"] = "sentry.dsc.project_id"
"""The ID of the project where the trace originated (i.e. the project of the SDK that started the trace). Propagated through the dynamic sampling context and set by Relay during ingestion.

Type: int
Type: str
Contains PII: false
Defined in OTEL: No
Visibility: internal
Example: 12345
Example: "12345"
"""

# Path: model/attributes/sentry/sentry__dsc__public_key.json
Expand Down Expand Up @@ -14334,11 +14334,11 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
),
"sentry.dsc.project_id": AttributeMetadata(
brief="The ID of the project where the trace originated (i.e. the project of the SDK that started the trace). Propagated through the dynamic sampling context and set by Relay during ingestion.",
type=AttributeType.INTEGER,
type=AttributeType.STRING,
pii=PiiInfo(isPii=IsPii.FALSE),
is_in_otel=False,
visibility=Visibility.INTERNAL,
example=12345,
example="12345",
changelog=[
ChangelogEntry(
version="0.7.0",
Expand Down Expand Up @@ -16525,7 +16525,7 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
"sentry.dist": str,
"sentry.domain": str,
"sentry.dsc.environment": str,
"sentry.dsc.project_id": int,
"sentry.dsc.project_id": str,
"sentry.dsc.public_key": str,
"sentry.dsc.release": str,
"sentry.dsc.sample_rate": str,
Expand Down
Loading