Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Nov 14, 2025

Adds customization to error messages in user feedback.

Closes: #4720

Closes #6824

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against d868a00

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@0a17f4a). Learn more about missing BASE report.
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...serFeedback/SentryUserFeedbackFormController.swift 0.000% 4 Missing ⚠️
...UserFeedback/SentryUserFeedbackFormViewModel.swift 90.000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #6790   +/-   ##
========================================
  Coverage        ?   84.589%           
========================================
  Files           ?       453           
  Lines           ?     27605           
  Branches        ?     10686           
========================================
  Hits            ?     23351           
  Misses          ?      4211           
  Partials        ?        43           
Files with missing lines Coverage Δ
...guration/SentryUserFeedbackFormConfiguration.swift 100.000% <100.000%> (ø)
...UserFeedback/SentryUserFeedbackFormViewModel.swift 86.094% <90.000%> (ø)
...serFeedback/SentryUserFeedbackFormController.swift 25.806% <0.000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a17f4a...d868a00. Read the comment docs.

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Nov 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.50 ms 1263.25 ms 37.75 ms
Size 24.14 KiB 1.01 MiB 1014.05 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
48e5c8a 1223.02 ms 1242.38 ms 19.35 ms
8fd192f 1202.10 ms 1220.19 ms 18.09 ms
5200f5b 1231.73 ms 1254.35 ms 22.62 ms
f8cad3c 1217.94 ms 1257.96 ms 40.02 ms
abe8da4 1232.98 ms 1259.12 ms 26.14 ms
4be5cd8 1222.35 ms 1251.43 ms 29.07 ms
af7a86c 1220.82 ms 1243.36 ms 22.54 ms
52f3b6e 1219.57 ms 1239.70 ms 20.13 ms
ebc72be 1221.24 ms 1249.66 ms 28.42 ms
1339919 1214.82 ms 1238.98 ms 24.16 ms

App size

Revision Plain With Sentry Diff
48e5c8a 23.75 KiB 913.63 KiB 889.88 KiB
8fd192f 23.74 KiB 872.75 KiB 849.01 KiB
5200f5b 23.75 KiB 933.33 KiB 909.58 KiB
f8cad3c 23.75 KiB 1.01 MiB 1016.13 KiB
abe8da4 23.75 KiB 987.95 KiB 964.21 KiB
4be5cd8 23.75 KiB 980.80 KiB 957.06 KiB
af7a86c 23.74 KiB 926.65 KiB 902.90 KiB
52f3b6e 23.75 KiB 920.54 KiB 896.79 KiB
ebc72be 23.75 KiB 908.22 KiB 884.47 KiB
1339919 23.75 KiB 919.70 KiB 895.95 KiB

Previous results on branch: itay/customizable_error_messages_user_feedback

Startup times

Revision Plain With Sentry Diff
0a4f9de 1226.93 ms 1257.07 ms 30.14 ms
0c266cf 1212.15 ms 1244.50 ms 32.35 ms
a7923cd 1226.25 ms 1260.19 ms 33.94 ms
8c54771 1229.91 ms 1260.40 ms 30.49 ms

App size

Revision Plain With Sentry Diff
0a4f9de 24.15 KiB 1.02 MiB 1016.05 KiB
0c266cf 24.14 KiB 1.01 MiB 1013.95 KiB
a7923cd 24.15 KiB 1.02 MiB 1016.05 KiB
8c54771 24.14 KiB 1.01 MiB 1014.01 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itaybre itaybre merged commit e5e08fa into main Nov 27, 2025
208 of 213 checks passed
@itaybre itaybre deleted the itay/customizable_error_messages_user_feedback branch November 27, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add options to customize UserFeedback error messages feedback: user-facing string configurability audit

4 participants