Skip to content

feat(r8-tests): Add R8 source file tests #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
romtsn wants to merge 3 commits into
base: rz/feat/r8-tests-synthetic
Choose a base branch
from
Open

feat(r8-tests): Add R8 source file tests #74

romtsn wants to merge 3 commits into from

Conversation

@romtsn
Copy link
Member

@romtsn romtsn commented Dec 23, 2025 •
edited
Loading

Part of #40

Unsure if we actually have to handle such weird inputs, but I guess we better be on the safe side and parse those correctly.

R8 Retrace Test Coverage

  • Inlining (13 tests) - inline frames, line numbers, source files, rewriteFrame rules
  • Ambiguous Methods (21 tests) - multiple methods → same obfuscated name, alternatives
  • Outlines (4 tests) - outline callsites, nested outlines, inline-in-outline
  • Synthetic/Lambda (3 tests) - lambda methods, synthetic bridges
  • Source File Edge Cases (7 tests) - colons, unicode, multiple dots, synthesized names
  • Line Number Handling (10 tests) - spans, preambles, invalid ranges, missing lines
  • Exception Handling (6 tests) - obfuscated exceptions, suppressed, circular refs
  • Method Overloading (4 tests) - overloads with/without ranges
  • Special Formats (4 tests) - Java 9+ modules, logcat format, auto-detect

@romtsn romtsn requested a review from loewenheim December 23, 2025 16:14
romtsn
romtsn commented Jan 21, 2026
View reviewed changes
tests/r8-source-file-edge-cases.NOTES.md

This note documents, **one-by-one**, what still needs fixing in the crate (not in the fixtures) to make the remaining tests pass.

## 1) `test_colon_in_file_name_stacktrace`
Copy link
Member Author

@romtsn romtsn Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs fixing

romtsn
romtsn commented Jan 21, 2026
View reviewed changes
tests/r8-source-file-edge-cases.NOTES.md
- In `parse_frame`, split `file:line` using the **last** colon (`rsplit_once(':')`) so file names can contain `:` (Windows paths and this fixture).
- Treat an empty or non-numeric suffix after the last colon as “no line info” (line `0`) instead of rejecting the frame.

## 2) `test_file_name_extension_stacktrace`
Copy link
Member Author

@romtsn romtsn Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skip this

romtsn
romtsn commented Jan 21, 2026
View reviewed changes
tests/r8-source-file-edge-cases.NOTES.md
- remap it,
- emit with the same prefix.

## 3) `test_class_with_dash_stacktrace`
Copy link
Member Author

@romtsn romtsn Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skip this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loewenheim loewenheim Awaiting requested review from loewenheim

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@romtsn