Skip to content

feat(r8-tests): Add R8 synthetic tests #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
romtsn wants to merge 2 commits into
base: rz/fix/r8-tests-ambiguous-no-line
Choose a base branch
from
Open

feat(r8-tests): Add R8 synthetic tests #73

romtsn wants to merge 2 commits into from

Conversation

@romtsn
Copy link
Member

@romtsn romtsn commented Dec 23, 2025 •
edited
Loading

Part of #40

The tests are currently failing because we just mark methods as synthetic but don't drop them in this crate. Unsure if we should align with retrace and just drop them cc @loewenheim ?

R8 Retrace Test Coverage

  • Inlining (13 tests) - inline frames, line numbers, source files, rewriteFrame rules
  • Ambiguous Methods (21 tests) - multiple methods → same obfuscated name, alternatives
  • Outlines (4 tests) - outline callsites, nested outlines, inline-in-outline
  • Synthetic/Lambda (3 tests) - lambda methods, synthetic bridges
  • Source File Edge Cases (7 tests) - colons, unicode, multiple dots, synthesized names
  • Line Number Handling (10 tests) - spans, preambles, invalid ranges, missing lines
  • Exception Handling (6 tests) - obfuscated exceptions, suppressed, circular refs
  • Method Overloading (4 tests) - overloads with/without ranges
  • Special Formats (4 tests) - Java 9+ modules, logcat format, auto-detect

@romtsn romtsn requested a review from loewenheim December 23, 2025 13:32
@loewenheim
Copy link
Contributor

loewenheim commented Jan 12, 2026

We could filter them out in remap_stacktrace, yeah. For the remap_stacktrace_typed I would leave it as it is.

@romtsn
Copy link
Member Author

romtsn commented Jan 21, 2026

we keept marking frames as synthesized and don't drop them in this crate. We can close this PR. We could also hide the synthesized frames in the Sentry UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loewenheim loewenheim Awaiting requested review from loewenheim

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@romtsn @loewenheim