Skip to content

Commit 5801edc

Browse files
test: Fix failing tests (#30)
A few of the tests are broken; they fail against the main branch, including in CI (see #28). This PR fixes the failing tests.
1 parent 1e9cb69 commit 5801edc

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

tests/test_envvars.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ def capture_event(self, event):
1212

1313
def capture_envelope(self, envelope):
1414
envelopes.append(envelope)
15+
if envelope.get_event() is not None:
16+
events.append(envelope.get_event())
1517

1618

1719
@pytest.fixture(autouse=True)

tests/test_retries.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
from __future__ import absolute_import
22

33
import pytest
4+
import sentry_sdk
45

56
from pytest_sentry import Client
67

@@ -9,16 +10,25 @@
910
events = []
1011

1112

13+
class MyTransport(sentry_sdk.Transport):
14+
def capture_event(self, event):
15+
events.append(event)
16+
17+
def capture_envelope(self, envelope):
18+
if envelope.get_event() is not None:
19+
events.append(envelope.get_event())
20+
21+
1222
@pytest.mark.flaky(reruns=2)
13-
@pytest.mark.sentry_client(Client(transport=events.append, traces_sample_rate=0.0))
23+
@pytest.mark.sentry_client(Client(transport=MyTransport(), traces_sample_rate=0.0))
1424
def test_basic(request):
1525
global i
1626
i += 1
1727
if i < 2:
1828
1 / 0
1929

2030

21-
@pytest.fixture(scope="session", autouse=True)
31+
@pytest.fixture(scope="module", autouse=True)
2232
def assert_report():
2333
yield
2434
(event,) = events

tests/test_tracing.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def test_basic(foo_fixture):
2727
assert foo_fixture == 42
2828

2929

30-
@pytest.fixture(scope="session", autouse=True)
30+
@pytest.fixture(scope="module", autouse=True)
3131
def assert_report():
3232
yield
3333

0 commit comments

Comments
 (0)