From 7aa6422216670d5641b44258bd68eb4a595331d2 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Wed, 30 Sep 2026 19:45:31 +0200 Subject: [PATCH] fix(changelog): disable @-mention pings in all publish issues MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #755 only stripped @-mentions from the publish-issue changelog for CalVer releases, on the theory that regular-cadence releases are the noisy ones. In practice any release that bundles more than a handful of PRs pings every contributor when the publish issue is created — e.g. getsentry/publish#9728 for devservices 1.5.2 (SemVer) notified everyone listed. Nobody needs a notification because their PR shipped in a release, so apply the same treatment regardless of versioning policy. The committed CHANGELOG.md is unaffected and keeps @-mentions, since those don't notify anyone. Co-Authored-By: Claude Opus 5.5 --- src/commands/prepare.ts | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/commands/prepare.ts b/src/commands/prepare.ts index 88e8c6cc..68b58fe3 100644 --- a/src/commands/prepare.ts +++ b/src/commands/prepare.ts @@ -964,16 +964,11 @@ export async function prepareMain(argv: PrepareOptions): Promise { setGitHubActionsOutput('sha', releaseSha); setGitHubActionsOutput('previous_tag', oldVersion || ''); if (changelogBody) { - // For CalVer releases, replace @-mentions with bold formatting in the - // changelog destined for publish issues, to avoid pinging many - // contributors on regular-cadence releases. The committed CHANGELOG.md - // keeps the original @-mentions (they don't create notifications). - const isCalVer = - argv.newVersion === 'calver' || - getVersioningPolicy() === VersioningPolicy.CalVer; - const issueChangelog = isCalVer - ? disableChangelogMentions(changelogBody) - : changelogBody; + // Replace @-mentions with bold formatting in the changelog destined for + // publish issues, otherwise every contributor in the release gets + // pinged. The committed CHANGELOG.md keeps the original @-mentions + // (they don't create notifications). + const issueChangelog = disableChangelogMentions(changelogBody); // Write full changelog to a file to avoid E2BIG when the action.yml // "Request publish" step expands it into an environment variable.