Repository navigation
Commit ab2e073
authored
fix(polyfill): add missing Bun.file().stat() shim for npm distribution (#838)
## Summary
- Fixes **CLI-1EA** (14 events) and **CLI-1EB** (420 events, escalating)
— both share a single root cause.
- Commit 9cb0d33 ("refactor(dsn): use Bun stat in regular-file guard",
released in **0.29.0**) swapped `stat` from `node:fs/promises` for
`Bun.file(path).stat()` in `isRegularFile()`. The Node polyfill in
`script/node-polyfills.ts` (injected at bundle time for the npm
distribution) never implemented `.stat()`, so every DSN auto-detection
call throws `TypeError: Bun.file(...).stat is not a function` on Node.
- The error is caught by `isRegularFile`'s `try/catch` but then captured
to Sentry (not in `isIgnorableFileError`'s allow-list), so npm users on
0.29.0 silently lose `.env` DSN detection + `.editorconfig` project-root
detection while spamming our Sentry project with handled TypeErrors.
## Fix
Extend `BunPolyfill.file(path)` with `stat: stat.bind(null, path)` —
aliases `stat` from `node:fs/promises` with the path pre-bound. No
wrapper closure needed; matches `Bun.file().stat()`'s zero-arg signature
exactly. `fs.stat` (not `lstat`) follows symlinks, matching Bun
semantics — critical for detecting 1Password `symlink → FIFO` chains.
Minimal one-line addition to the polyfill + a new `stat` in the existing
top-level `node:fs/promises` import.
## Tests
- Extended `test/script/node-polyfills.test.ts` (the existing
`polyfillFile()` reproduction) with 5 new `.stat()` cases: regular file,
directory, non-existent path (ENOENT), symlink following, and parity
with native `Bun.file().stat()`.
- Added `test/lib/node-polyfills-file-stat.test.ts` — a mirror that
lives under the `bun run test:unit` glob so CI actually runs it (the
`test/script/` directory is not in any CI test script per AGENTS.md).
All 39 polyfill tests pass; full `bun test test/lib` is green (4192
pass, 0 fail).
## Release
Intended as the content of a **0.29.1 patch release** (will cut after
merge).
## Verification
- [x] `bun run typecheck` — clean
- [x] `bun run lint` — only pre-existing warning in
`src/lib/formatters/markdown.ts` (not touched)
- [x] `bun test test/lib` — 4192 pass, 0 fail
- [x] `bun test test/script/node-polyfills.test.ts
test/lib/node-polyfills-file-stat.test.ts` — 39 pass1 parent 1cd5c76 commit ab2e073
3 files changed
Lines changed: 182 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
| 130 | + | |
| 131 | + | |
130 | 132 | | |
131 | 133 | | |
132 | 134 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| |||
339 | 340 | | |
340 | 341 | | |
341 | 342 | | |
| 343 | + | |
| 344 | + | |
342 | 345 | | |
343 | 346 | | |
344 | 347 | | |
| |||
415 | 418 | | |
416 | 419 | | |
417 | 420 | | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
418 | 495 | | |
419 | 496 | | |
420 | 497 | | |
| |||
0 commit comments