fix(error-reporting): silence undici TypeError: terminated network errors (CLI-2AD)

Author: sentry[bot]

packages/cli/src/lib/error-reporting.ts

@@ -76,7 +76,9 @@ export function classifySilenced(error: unknown): SilenceReason | null {
     return "output_error";
   }
   // A raw `TypeError: "fetch failed"` (CLI-16W) means the CLI could not reach
-  // Sentry at all (offline, DNS, connection refused/timeout). There is nothing
+  // Sentry at all (offline, DNS, connection refused/timeout); a raw
+  // `TypeError: "terminated"` (CLI-2AD) means the connection dropped while
+  // streaming the response body. There is nothing
   // actionable in a "user is offline" report, so drop it — same rationale as
   // EPIPE/EBADF OS noise in `beforeSend`. Note: TLS cert errors are wrapped as
   // ApiError(status 0), NOT matched here, so they stay captured/actionable.

packages/cli/src/lib/errors.ts

@@ -911,6 +911,11 @@ export function toSearchQueryError(
  * `TypeError: "fetch failed"` for every such failure (the real errno is in
  * `cause`).
  *
+ * When the connection drops *after* response headers arrive (e.g. `read
+ * ETIMEDOUT` while streaming the body), undici instead aborts the body stream
+ * with `TypeError: "terminated"` (CLI-2AD). That is the same class of
+ * environmental failure, so it is matched too.
+ *
  * This reflects the user's environment, not a CLI bug, so it is treated as a
  * user error (no upgrade nudge) and is not reported to Sentry — the same
  * rationale as dropping EPIPE/EBADF OS noise in `beforeSend`.
@@ -922,7 +927,10 @@ export function toSearchQueryError(
  * CLI bug" treatment for `status === 0` check it explicitly.
  */
 export function isNetworkError(error: unknown): boolean {
-  return error instanceof TypeError && error.message === "fetch failed";
+  return (
+    error instanceof TypeError &&
+    (error.message === "fetch failed" || error.message === "terminated")
+  );
 }
 
 /**

packages/cli/test/lib/error-reporting.test.ts

@@ -251,6 +251,13 @@ describe("classifySilenced", () => {
     );
   });
 
+  test("silences a raw 'terminated' TypeError (mid-body connection drop)", () => {
+    const err = new TypeError("terminated", {
+      cause: new Error("read ETIMEDOUT"),
+    });
+    expect(classifySilenced(err)).toBe("network_error");
+  });
+
   test("does NOT silence a TLS cert error wrapped as ApiError(0)", () => {
     // status 0 is shared by network failures and TLS cert errors; the latter
     // are actionable (missing CA) and must stay captured.

packages/cli/test/lib/errors.test.ts

@@ -536,6 +536,11 @@ describe("isUserError", () => {
       new TypeError("fetch failed"),
       true,
     ],
+    [
+      "raw terminated TypeError (mid-body network drop)",
+      new TypeError("terminated"),
+      true,
+    ],
     ["ApiError 400", new ApiError("bad request", 400), false],
     [
       // A user's unparseable --query becomes a ValidationError at the command
@@ -565,6 +570,18 @@ describe("isNetworkError", () => {
     expect(isNetworkError(new TypeError("fetch failed"))).toBe(true);
   });
 
+  test("true for a raw 'terminated' TypeError (mid-body connection drop)", () => {
+    const err = new TypeError("terminated", {
+      cause: new Error("read ETIMEDOUT"),
+    });
+    expect(isNetworkError(err)).toBe(true);
+    expect(isNetworkError(new TypeError("terminated"))).toBe(true);
+  });
+
+  test("false for a plain Error with message 'terminated'", () => {
+    expect(isNetworkError(new Error("terminated"))).toBe(false);
+  });
+
   test("false for ApiError status 0 (shared with TLS cert errors)", () => {
     // status 0 is also used for TLS cert errors, which must stay actionable.
     expect(isNetworkError(new ApiError("Network error", 0))).toBe(false);