Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use html tag in description @version 3.0.0 #2146

Closed
orkShinnosuke opened this issue Dec 10, 2017 · 3 comments
Closed

Cannot use html tag in description @version 3.0.0 #2146

orkShinnosuke opened this issue Dec 10, 2017 · 3 comments

Comments

@orkShinnosuke
Copy link

orkShinnosuke commented Dec 10, 2017

Issue Summary

Cannot use html tag in description

2017-12-10 16 05 07

P.S.
also cannot use in dashboards

Steps to Reproduce

  1. Look at below link
    http://demo.redash.io/queries/5873/source
    http://demo.redash.io/dashboard/test_1103

Technical details:

  • Redash Version: 3.0.0
  • Browser/OS: google chrome/macOS Sierra(10.12.6)
@kyoshidajp
Copy link
Member

I figure HTML tag isn't be able to use after v3.0.0.

Markdown library has changed from marked to markdown by #1966. markdown package do sanitize HTML, and can't disable it.

Actually, the PR disable sanitize option is already sent by evilstreak/markdown-js#132 in many years ago. However, it's not merged yet.

Why don’t you use markdown format?

@arikfr
Copy link
Member

arikfr commented Dec 11, 2017

@kyoshidajp is correct - this is due to the change in Markdown parser and we don't expect to bring this back (as this was never the intended behavior).

Just use Markdown.

@arikfr arikfr closed this as completed Dec 11, 2017
@orkShinnosuke
Copy link
Author

@kyoshidajp @arikfr
Thanks! I'll use Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants