fix(credentials): return nil instead of empty error group

kichristensen · kichristensen · commit d7910292c560 · 2025-01-02T09:18:58.000+01:00
- Update ResolveAll to return ErrorOrNil() instead of raw error group
- Ensures consistent error handling when no errors occurred during resolution

Signed-off-by: Kim Christensen &lt;kimworking@gmail.com&gt;
diff --git a/pkg/storage/credential_store.go b/pkg/storage/credential_store.go
@@ -88,7 +88,7 @@ func (s CredentialStore) ResolveAll(ctx context.Context, creds CredentialSet, ke
 		resolvedCreds[cred.Name] = value
 	}
 
-	return resolvedCreds, resolveErrors
+	return resolvedCreds, resolveErrors.ErrorOrNil()
 }
 
 func (s CredentialStore) Validate(ctx context.Context, creds CredentialSet) error {

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ func (s CredentialStore) ResolveAll(ctx context.Context, creds CredentialSet, ke`
`88`	`88`	`resolvedCreds[cred.Name] = value`
`89`	`89`	`}`
`90`	`90`
`91`		`- return resolvedCreds, resolveErrors`
	`91`	`+ return resolvedCreds, resolveErrors.ErrorOrNil()`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`func (s CredentialStore) Validate(ctx context.Context, creds CredentialSet) error {`