refactor(credentials): modify GetCredential to return pointer for in-place updates

- Change GetCredential signature to return *secrets.SourceMap instead of value
- Update loadCredentials to use Keys() iterator for credential lookup
- Add explicit error handling for missing credentials
- Fix credential value updates to modify original values via pointers

Signed-off-by: Kim Christensen <[email protected]>

Author: kichristensen

pkg/cnab/provider/credentials.go

@@ -17,8 +17,12 @@ func (r *Runtime) loadCredentials(ctx context.Context, b cnab.ExtendedBundle, ru
 		return span.Error(err)
 	}
 
-	for i, cred := range run.Credentials.Credentials {
-		run.Credentials.Credentials[i].ResolvedValue = resolvedCredentials[cred.Name]
+	for _, key := range run.Credentials.Keys() {
+		cred, ok := run.Credentials.GetCredential(key)
+		if !ok {
+			return span.Errorf("credential %s not found", key)
+		}
+		cred.ResolvedValue = resolvedCredentials[key]
 	}
 
 	err = run.Credentials.ValidateBundle(b.Credentials, run.Action)

pkg/storage/credentialset.go

@@ -196,11 +196,11 @@ func (s CredentialSet) Keys() []string {
 }
 
 // GetCredential returns the credential with the given name, and a boolean indicating if it was found.
-func (s CredentialSet) GetCredential(name string) (secrets.SourceMap, bool) {
+func (s CredentialSet) GetCredential(name string) (*secrets.SourceMap, bool) {
 	for _, cred := range s.Credentials {
 		if cred.Name == name {
-			return cred, true
+			return &cred, true
 		}
 	}
-	return secrets.SourceMap{}, false
+	return nil, false
 }