Print out why we couldn't parse show output in the test helper

carolynvs · carolynvs · commit 1ab0221f08d5 · 2023-04-26T10:02:53.000-05:00
Signed-off-by: Carolyn Van Slyck &lt;me@carolynvanslyck.com&gt;
diff --git a/tests/tester/helpers.go b/tests/tester/helpers.go
@@ -62,7 +62,10 @@ func (t Tester) ShowInstallation(namespace string, name string) (porter.DisplayI
 
 	var di porter.DisplayInstallation
 
-	require.NoError(t.T, json.Unmarshal([]byte(stdout), &di))
+	err = json.Unmarshal([]byte(stdout), &di)
+	if err != nil {
+		t.T.Fatalf("porter show returned non-json output to stdout: %s", stdout)
+	}
 
 	return di, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,10 @@ func (t Tester) ShowInstallation(namespace string, name string) (porter.DisplayI`
`62`	`62`
`63`	`63`	`var di porter.DisplayInstallation`
`64`	`64`
`65`		`- require.NoError(t.T, json.Unmarshal([]byte(stdout), &di))`
	`65`	`+ err = json.Unmarshal([]byte(stdout), &di)`
	`66`	`+ if err != nil {`
	`67`	`+ t.T.Fatalf("porter show returned non-json output to stdout: %s", stdout)`
	`68`	`+ }`
`66`	`69`
`67`	`70`	`return di, nil`
`68`	`71`	`}`