Incorrect handling on non-JSON error response bodies

[hjl-tools]

While trying to apply a glibc patch,

https://patchwork.sourceware.org/project/glibc/patch/[email protected]/

I got

$ git pw patch apply 105376

Traceback (most recent call last):
  File "/usr/lib/python3.13/site-packages/requests/models.py", line 974, in json
    return complexjson.loads(self.text, **kwargs)
           ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.13/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
           ~~~~~~~~~~~~~~~~~~~~~~~^^^
  File "/usr/lib64/python3.13/json/decoder.py", line 345, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
               ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.13/json/decoder.py", line 363, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/export/home/hjl/.local/bin/git-pw", line 8, in <module>
    sys.exit(cli())
             ~~~^^
  File "/usr/lib/python3.13/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python3.13/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/export/home/hjl/.local/lib/python3.13/site-packages/git_pw/patch.py", line 86, in apply_cmd
    patch = api.detail('patches', patch_id)
  File "/export/home/hjl/.local/lib/python3.13/site-packages/git_pw/api.py", line 342, in detail
    return _get(url, params, stream=False).json()
           ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/export/home/hjl/.local/lib/python3.13/site-packages/git_pw/api.py", line 160, in _get
    _handle_error('fetch', exc)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/export/home/hjl/.local/lib/python3.13/site-packages/git_pw/api.py", line 125, in _handle_error
    LOG.error(exc.response.json())
              ~~~~~~~~~~~~~~~~~^^
  File "/usr/lib/python3.13/site-packages/requests/models.py", line 978, in json
    raise RequestsJSONDecodeError(e.msg, e.doc, e.pos)
requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

[stephenfin]

I would be surprised if this was specific to Fedora 41: that's what I use and I don't see any issues.

There is a bug with git-pw here, which I have now addressed. However, the ultimate issue is likely on the server side. Hopefully the fixed version will give you more context about what that might be. I would also suggest running with the --debug flag, since that should dump the raw requests and responses.