Skip to content

Commit cf80c6e

Browse files
committed
Replace implicit optional typedefs
Signed-off-by: Stephen Finucane <[email protected]>
1 parent 950b15c commit cf80c6e

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

Diff for: git_pw/api.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ def _handle_error(
138138

139139
def _get(
140140
url: str,
141-
params: Filters = None,
141+
params: ty.Optional[Filters] = None,
142142
stream: bool = False,
143143
) -> requests.Response:
144144
"""Make GET request and handle errors."""
@@ -236,8 +236,8 @@ def version() -> ty.Tuple[int, int]:
236236

237237
def download(
238238
url: str,
239-
params: Filters = None,
240-
output: ty.Optional[str] = None,
239+
params: ty.Optional[Filters] = None,
240+
output: ty.Optional[ty.Optional[str]] = None,
241241
) -> ty.Optional[str]:
242242
"""Retrieve a specific API resource and save it to a file/stdout.
243243
@@ -293,7 +293,7 @@ def download(
293293
return output_path
294294

295295

296-
def index(resource_type: str, params: Filters = None) -> dict:
296+
def index(resource_type: str, params: ty.Optional[Filters] = None) -> dict:
297297
"""List API resources.
298298
299299
GET /{resource}/
@@ -322,7 +322,7 @@ def index(resource_type: str, params: Filters = None) -> dict:
322322
def detail(
323323
resource_type: str,
324324
resource_id: ty.Union[str, int],
325-
params: Filters = None,
325+
params: ty.Optional[Filters] = None,
326326
) -> ty.Dict:
327327
"""Retrieve a specific API resource.
328328

Diff for: git_pw/utils.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,8 @@ def _pagination_options(f):
208208

209209

210210
def format_options(
211-
original_function: ty.Callable = None,
212-
headers: ty.Tuple[str, ...] = None,
211+
original_function: ty.Optional[ty.Callable] = None,
212+
headers: ty.Optional[ty.Tuple[str, ...]] = None,
213213
) -> ty.Callable:
214214
"""Shared output format options."""
215215

0 commit comments

Comments
 (0)