Skip to content

Revert http-177 and allow user to specify http version on lookup httprequests. #179

@davidradl

Description

@davidradl

#178 was added incorrectly, it changed the sink version from 1.1 to 2. The intent was actually to solve a problem talking to langflow webhooks. Where we were getting
Invalid HTTP request received
HTTP/2 upgrade not supported

  • In the http connector - the existing lookup http client and request calls do not specify a version on the HttpClient or HttpRequest 
  • In the http connector - the sink http requests for batch and per request was HTTP_1_1, I recently changed this to HTTP_2 in HTTP-177
  • Running the http connector with a lookup against a langflow flow with /run/ in the base URL. This works in curl and with the http connector 
  • Running the http connector with a lookup against a langflow flow with a webhook, exposes an API containing with /webhook/ in the base URL.
    • This works in curl and fails with the reported error using the http client. 
    • If I change the http connector so the httprequest has version HTTP_1_1 version, it works.

Proposed changes:

the recent change to http connector sink - was not correct and when I tested it - my test was not driving the fix . We need to

  • revert the sink HTTPRequest to HTTP_1_1, at least.
  • change the lookup connector to allow HTTP_1_1 to be specified. Introduce a new config for lookup with enumerations none, 1.1 and 2.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions