Skip to content

Commit 5df5a4a

Browse files
committed
ci(github/smoketest): fix dockerhub-login action and call it before heavy setup
1 parent a86aa41 commit 5df5a4a

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed
Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
1-
name: login to Dockerhub (to prevent image trottling)
1+
name: login to Dockerhub (to prevent image pull trottling)
22
runs:
33
using: composite
44
steps:
55
- name: docker login
6-
run: bash -ce 'echo "$DOCKERHUB_PASSWORD" | docker login -u "$DOCKERHUB_USERNAME" --password-stdin'
6+
run: |
7+
docker login -u "$DOCKERHUB_USERNAME" --password-stdin <<< "$DOCKERHUB_PASSWORD"
8+
shell: bash
79
env:
8-
DOCKERHUB_PASSWORD: {{ secrets.DOCKERHUB_PASSWORD }}
9-
DOCKERHUB_USERNAME: {{ secrets.DOCKERHUB_USERNAME }}
10+
DOCKERHUB_PASSWORD: ${{ secrets.DOCKERHUB_PASSWORD }}
11+
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}

.github/workflows/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ jobs:
4747
#needs: [ 'lint','test' ]
4848
steps:
4949
- uses: actions/checkout@v5
50-
- uses: ./.github/actions/setup
51-
id: setup
5250
- uses: ./.github/actions/dockerhub-login
51+
- id: setup
52+
uses: ./.github/actions/setup
5353
- run: poetry build
5454
- run: ci/run_tests.sh
5555
env:

0 commit comments

Comments
 (0)