functionalize check_link for cleaner logic

Author: scivision

cmake/Modules/FindHDF5.cmake

@@ -309,72 +309,24 @@ set(HDF5_HL_FOUND true PARENT_SCOPE)
 
 endfunction(find_hdf5_c)
 
-# === main program
-
-set(CMAKE_REQUIRED_LIBRARIES)
 
-# we don't use pkg-config names because some distros pkg-config for HDF5 is broken
-# however at least the paths are often correct
-find_package(PkgConfig)
-if(NOT HDF5_FOUND)
-  if(parallel IN_LIST HDF5_FIND_COMPONENTS)
-    pkg_search_module(pc_hdf5 hdf5-openmpi hdf5-mpich hdf5)
-  else()
-    pkg_search_module(pc_hdf5 hdf5-serial hdf5)
-  endif()
-endif()
+function(check_hdf5_link)
 
-set(_lsuf hdf5)
-if(parallel IN_LIST HDF5_FIND_COMPONENTS)
-  list(PREPEND _lsuf openmpi/lib mpich/lib hdf5/openmpi hdf5/mpich)
-else()
-  list(PREPEND _lsuf hdf5/serial)
-endif()
-
-set(_psuf static ${_lsuf})
-if(parallel IN_LIST HDF5_FIND_COMPONENTS)
-  list(PREPEND _psuf openmpi-x86_64 mpich-x86_64)
-endif()
-
-set(_msuf ${_psuf})
-if(CMAKE_Fortran_COMPILER_ID STREQUAL GNU)
-  list(APPEND _msuf gfortran/modules)
-  if(parallel IN_LIST HDF5_FIND_COMPONENTS)
-    list(PREPEND _msuf gfortran/modules/openmpi gfortran/modules/mpich)
-  endif()
-endif()
-# Not immediately clear the benefits of this, as we'd have to foreach()
-# a priori names, kind of like we already do with find_library()
-# find_package(hdf5 CONFIG)
-# message(STATUS "hdf5 found ${hdf5_FOUND}")
-
-if(Fortran IN_LIST HDF5_FIND_COMPONENTS)
-  find_hdf5_fortran()
-endif()
-
-if(CXX IN_LIST HDF5_FIND_COMPONENTS)
-  find_hdf5_cxx()
+if(NOT HDF5_C_FOUND)
+  return()
 endif()
 
-# C is always needed
-find_hdf5_c()
-
-# required libraries
-if(HDF5_C_FOUND)
-  detect_config()
-endif(HDF5_C_FOUND)
-
-# --- configure time checks
-# these checks avoid messy, confusing errors at build time
-
-if(HDF5_C_FOUND)
-
 list(PREPEND CMAKE_REQUIRED_LIBRARIES ${HDF5_C_LIBRARIES})
 set(CMAKE_REQUIRED_INCLUDES ${HDF5_C_INCLUDE_DIR})
 
 if(HDF5_parallel_FOUND)
   list(APPEND CMAKE_REQUIRED_LIBRARIES MPI::MPI_C)
 
+  check_symbol_exists(H5Pset_fapl_mpio hdf5.h HAVE_H5Pset_fapl_mpio)
+  if(NOT HAVE_H5Pset_fapl_mpio)
+    return()
+  endif()
+
   set(src [=[
   #include "hdf5.h"
   #include "mpi.h"
@@ -398,20 +350,21 @@ else()
   #include "hdf5.h"
 
   int main(void){
-  hid_t f = H5Fcreate ("junk.h5", H5F_ACC_TRUNC, H5P_DEFAULT, H5P_DEFAULT);
+  hid_t f = H5Fcreate("junk.h5", H5F_ACC_TRUNC, H5P_DEFAULT, H5P_DEFAULT);
   herr_t status = H5Fclose (f);
   return 0;}
   ]=])
 endif(HDF5_parallel_FOUND)
 
 check_c_source_compiles("${src}" HDF5_C_links)
 
-set(HDF5_links ${HDF5_C_links})
+if(NOT HDF5_C_links)
+  return()
+endif()
 
-endif(HDF5_C_FOUND)
 
 
-if(HDF5_Fortran_FOUND AND HDF5_links)
+if(HDF5_Fortran_FOUND)
 
 list(PREPEND CMAKE_REQUIRED_LIBRARIES ${HDF5_Fortran_LIBRARIES})
 set(CMAKE_REQUIRED_INCLUDES ${HDF5_Fortran_INCLUDE_DIR} ${HDF5_C_INCLUDE_DIR})
@@ -451,18 +404,76 @@ endif()
 
 check_fortran_source_compiles(${src} HDF5_Fortran_links SRC_EXT f90)
 
-
 if(NOT HDF5_Fortran_links)
-  set(HDF5_Fortran_links false)
+  return()
 endif()
 
-endif(HDF5_Fortran_FOUND AND HDF5_links)
+endif(HDF5_Fortran_FOUND)
+
+
+set(HDF5_links true PARENT_SCOPE)
+
+endfunction(check_hdf5_link)
+
+# === main program
 
+set(CMAKE_REQUIRED_LIBRARIES)
 
-if(HDF5_Fortran_FOUND AND NOT HDF5_Fortran_links)
-  set(HDF5_links false)
+# we don't use pkg-config names because some distros pkg-config for HDF5 is broken
+# however at least the paths are often correct
+find_package(PkgConfig)
+if(NOT HDF5_FOUND)
+  if(parallel IN_LIST HDF5_FIND_COMPONENTS)
+    pkg_search_module(pc_hdf5 hdf5-openmpi hdf5-mpich hdf5)
+  else()
+    pkg_search_module(pc_hdf5 hdf5-serial hdf5)
+  endif()
 endif()
 
+set(_lsuf hdf5)
+if(parallel IN_LIST HDF5_FIND_COMPONENTS)
+  list(PREPEND _lsuf openmpi/lib mpich/lib hdf5/openmpi hdf5/mpich)
+else()
+  list(PREPEND _lsuf hdf5/serial)
+endif()
+
+set(_psuf static ${_lsuf})
+if(parallel IN_LIST HDF5_FIND_COMPONENTS)
+  list(PREPEND _psuf openmpi-x86_64 mpich-x86_64)
+endif()
+
+set(_msuf ${_psuf})
+if(CMAKE_Fortran_COMPILER_ID STREQUAL GNU)
+  list(APPEND _msuf gfortran/modules)
+  if(parallel IN_LIST HDF5_FIND_COMPONENTS)
+    list(PREPEND _msuf gfortran/modules/openmpi gfortran/modules/mpich)
+  endif()
+endif()
+# Not immediately clear the benefits of this, as we'd have to foreach()
+# a priori names, kind of like we already do with find_library()
+# find_package(hdf5 CONFIG)
+# message(STATUS "hdf5 found ${hdf5_FOUND}")
+
+if(Fortran IN_LIST HDF5_FIND_COMPONENTS)
+  find_hdf5_fortran()
+endif()
+
+if(CXX IN_LIST HDF5_FIND_COMPONENTS)
+  find_hdf5_cxx()
+endif()
+
+# C is always needed
+find_hdf5_c()
+
+# required libraries
+if(HDF5_C_FOUND)
+  detect_config()
+endif(HDF5_C_FOUND)
+
+# --- configure time checks
+# these checks avoid messy, confusing errors at build time
+check_hdf5_link()
+
 set(CMAKE_REQUIRED_LIBRARIES)
 set(CMAKE_REQUIRED_INCLUDES)