Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapstore - rename docker image #3501

Closed
fvanderbiest opened this issue Sep 13, 2021 · 9 comments · May be fixed by georchestra/mapstore2-georchestra#496
Closed

mapstore - rename docker image #3501

fvanderbiest opened this issue Sep 13, 2021 · 9 comments · May be fixed by georchestra/mapstore2-georchestra#496
Assignees
Milestone

Comments

@fvanderbiest
Copy link
Member

fvanderbiest commented Sep 13, 2021

Rename georchestra/mapstore2-georchestra docker image into georchestra/mapstore

@fvanderbiest fvanderbiest added this to the 21.0.0 milestone Sep 13, 2021
@fvanderbiest fvanderbiest self-assigned this Jan 7, 2022
@fvanderbiest
Copy link
Member Author

fvanderbiest commented Jan 7, 2022

Here's my understanding:

@fvanderbiest
Copy link
Member Author

This also relates to georchestra/mapstore2-georchestra#425

@fvanderbiest fvanderbiest assigned pmauduit and tkohr and unassigned fvanderbiest Mar 10, 2022
@jmbourdaret jmbourdaret self-assigned this Mar 11, 2022
@jmbourdaret
Copy link
Contributor

some additional information about configuration and versions: georchestra/docker#122

@jmbourdaret
Copy link
Contributor

Here's my understanding:

what about the https://github.com/georchestra/MapStore2 repo (fork of geosolutions's )? is it replaced by https://github.com/georchestra/mapstore2-georchestra ?

@pmauduit
Copy link
Member

what about the https://github.com/georchestra/MapStore2 repo (fork of geosolutions's )? is it replaced by https://github.com/georchestra/mapstore2-georchestra ?

I think it was used previously because a hack was required somehow (ping @tkohr for confirmation). The repositories are not equivalent though, one is used as a submodule for the other one: georchestra/Mapstore2 is a fork from geosolutions-it/Mapstore2, which is integrated as a submodule into georchestra/mapstore2-georchestra.

@tkohr
Copy link
Contributor

tkohr commented Mar 11, 2022

We created the https://github.com/georchestra/MapStore2 fork last fall, when we needed a recent dev (that had been merged in Mapstore2) without updating the entire submodule, which included other obstacles: georchestra/mapstore2-georchestra#427
Since then, several updates of the submodule have been applied and the fork should not be in use anymore. I guess we could remove it.

@jmbourdaret
Copy link
Contributor

jmbourdaret commented Mar 11, 2022

indeed. thanks Tobias
https://github.com/georchestra/mapstore2-georchestra/commits/master/.gitmodules

it doesn't seems to be used anymore.
( edit: I don't have the rights to archive the repo )

@tkohr
Copy link
Contributor

tkohr commented Mar 11, 2022

Me neither, I think @pmauduit can help out here ;)

@pmauduit
Copy link
Member

Me neither, I think @pmauduit can help out here ;)

done, I archived georchestra/MapStore2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants