Skip to content

Guidelines for contributing #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alex-translation opened this issue Apr 6, 2022 · 5 comments
Closed

Guidelines for contributing #183

alex-translation opened this issue Apr 6, 2022 · 5 comments

Comments

@alex-translation
Copy link

alex-translation commented Apr 6, 2022

Hello,

I'm loving using this project, and would love to contribute to it. The feature parity post seems like a great place to start.

And it seems like the guide for contributing to GeoPandas largely applies here as well.

Are there any substantial changes to those docs, either the list of features or the contributing guidelines? Edit: Especially curious about dependencies and testing that only apply here.

Thanks in advance, excited to learn.


Best,
Alex

@jorisvandenbossche
Copy link
Member

Thanks for your interest in contributing!

And it seems like the guide for contributing to GeoPandas largely applies here as well.

Indeed, the general GeoPandas contributing guidelines should apply here as well. I see that our CONTRIBUTING.md file still points to dask (https://github.com/geopandas/dask-geopandas/blob/main/CONTRIBUTING.md), we can maybe update that to point to geopandas.

The #130 seems like a great place to start.

Most of the easy ones are already done by now, I think, but I added an update to that issue.

#76 might be another good first issue. Also #79 or #81 should be doable but require some more advanced dask experience.

@alex-translation
Copy link
Author

alex-translation commented Apr 6, 2022

#76 looks interesting. Is this referring to the class on line 884 and NotImplementedError on line 911 of the core.py file? Sign me up for this one.

@alex-translation
Copy link
Author

alex-translation commented Apr 6, 2022

I asked about dependencies and pytest because the default imports and tests led to some package version conflicts and failed tests. I resolved the imports, but have some questions about the tests. Issue #76 seems relatively simple, so I'm not sure what's absolutely essential here, but I do want to follow the contribution guidelines (all of which make sense to me).

Running pytest on a new conda environment leads to 10 failed, 151 passed, 4 skipped, 2 xfailed, 1009 warnings in 38.38s. It's quite a lot of output; should I paste it all here?

@martinfleis
Copy link
Member

It's quite a lot of output; should I paste it all here?

Can you open an issue for that?

@alex-translation
Copy link
Author

It's quite a lot of output; should I paste it all here?

Can you open an issue for that?

@martinfleis here's the issue I made for this #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants