Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make internal imports as relative path #85

Closed
ricardogsilva opened this issue Jan 3, 2025 · 1 comment · Fixed by #89
Closed

make internal imports as relative path #85

ricardogsilva opened this issue Jan 3, 2025 · 1 comment · Fixed by #89
Assignees
Milestone

Comments

@ricardogsilva
Copy link
Collaborator

atm, internal imports starts with geoserverx

from geoserverx.models.coverages_layer import CoverageModel
from geoserverx.models.coverages_store import CoveragesStoreModel, CoveragesStoresModel

Let's use relative imports instead:

from ..models.coverages_layer import CoverageModel
from ..models.coverages_store import CoveragesStoreModel, CoveragesStoresModel

this will help developer to understand what is internal and what is 3rd party dependent.

@krishnaglodha
Copy link
Collaborator

#89 raised

@krishnaglodha krishnaglodha moved this from Todo to In review in geoserverx Jan 9, 2025
@krishnaglodha krishnaglodha linked a pull request Jan 9, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from In review to Done in geoserverx Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants