Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove async/sync from CLI #78

Closed
ricardogsilva opened this issue Jan 3, 2025 · 0 comments · Fixed by #81
Closed

remove async/sync from CLI #78

ricardogsilva opened this issue Jan 3, 2025 · 0 comments · Fixed by #81
Assignees
Milestone

Comments

@ricardogsilva
Copy link
Collaborator

Our CLI should not expose the underlying sync/async implementation details of its commands.

This means we will be free to implement commands in the most suitable way, and clients of the CLI would not need to worry about how the results are produced, only that they are correct.

With this in mind, let's remove all --request CLI options. Let's use the sync implementation under the hood for now - we may decide to switch it with the async one in the future (or even use a mixture, if that somehow would make sense).

Sometime in the future, when the project is more robust, we may want to bring this feature back. But for now let's remove it.

@ricardogsilva ricardogsilva converted this from a draft issue Jan 3, 2025
@ricardogsilva ricardogsilva moved this from Backlog to Todo in geoserverx Jan 3, 2025
@krishnaglodha krishnaglodha added this to the Jan 2025 milestone Jan 3, 2025
krishnaglodha added a commit that referenced this issue Jan 3, 2025
@krishnaglodha krishnaglodha moved this from Todo to In review in geoserverx Jan 3, 2025
@ricardogsilva ricardogsilva moved this from In review to In progress in geoserverx Jan 3, 2025
@krishnaglodha krishnaglodha moved this from In progress to In review in geoserverx Jan 3, 2025
@krishnaglodha krishnaglodha linked a pull request Jan 3, 2025 that will close this issue
@krishnaglodha krishnaglodha moved this from In review to Done in geoserverx Jan 15, 2025
@krishnaglodha krishnaglodha closed this as completed by moving to Done in geoserverx Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants