Format BigDecimal values must round HALF_UP (#961)

Issue 203511

Author: iroqueta

common/src/main/java/com/genexus/LocalUtil.java

@@ -1,5 +1,6 @@
 package com.genexus;
 
+import java.math.RoundingMode;
 import java.util.*;
 import java.text.*;
 
@@ -1713,6 +1714,7 @@ private String formatBigDecimal(java.math.BigDecimal value, String picture, Numb
 		{
 			DecimalFormat df = (DecimalFormat) numberFormat;
 			df.applyPattern(pictureToNumberFormat(withoutSuffixPicture));
+			df.setRoundingMode(RoundingMode.HALF_UP);
 			if ( CommonUtil.in(picture, '.') || CommonUtil.in(picture, ','))
 			{
 				formatted = alignAndPad(df.format(value), '0', withoutSuffixPicture, floating, numberFormat, originalPicture);

java/src/test/java/com/genexus/TestCommonUtil.java

@@ -204,6 +204,13 @@ public void testFormat() {
 		result = ui.getLocalUtil().format(bigDecimalValue, picture);
 		Assert.assertEquals(expectedResult, result);
 
+		bigDecimalValue = new BigDecimal(2.5);
+		picture = "Z,ZZZ,ZZZ,ZZZ,ZZZ,ZZ9";
+		expectedResult = "                    3";
+
+		result = ui.getLocalUtil().format(bigDecimalValue, picture);
+		Assert.assertEquals(expectedResult, result);
+
 		bigDecimalValue = new BigDecimal(-12.5);
 		picture = "$Z9.9";
 		expectedResult = "-$12.5";