Skip to content

Commit 62da8ed

Browse files
authored
Improve naming (#2)
1 parent 48203e5 commit 62da8ed

2 files changed

Lines changed: 14 additions & 24 deletions

File tree

dist/index.js

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27115,6 +27115,7 @@ var __webpack_exports__ = {};
2711527115
const S3 = __nccwpck_require__(3256);
2711627116
const core = __nccwpck_require__(2186);
2711727117
const fs = __nccwpck_require__(7147);
27118+
const path = __nccwpck_require__(1017);
2711827119

2711927120
try {
2712027121
const endpoint = core.getInput('endpoint');
@@ -27131,18 +27132,12 @@ try {
2713127132
signatureVersion: 'v4',
2713227133
});
2713327134

27134-
var uploadParams = { Bucket: bucket, Key: '', Body: '' };
27135-
27136-
var fileStream = fs.createReadStream(file);
27137-
fileStream.on('error', function (err) {
27138-
console.log('File Error', err);
27139-
core.setFailed(err);
27140-
});
27141-
uploadParams.Body = fileStream;
27142-
if (destination == "") {
27143-
var path = __nccwpck_require__(1017);
27144-
uploadParams.Key = path.basename(file);
27145-
} else { uploadParams.Key = destination; }
27135+
const fileContent = fs.readFileSync(file);
27136+
let uploadParams = {
27137+
Bucket: bucket,
27138+
Key: destination ? destination : path.basename(file),
27139+
Body: fileContent
27140+
};
2714627141

2714727142
// call S3 to retrieve upload file to specified bucket
2714827143
s3.upload(uploadParams, function (err, data) {

index.js

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
const S3 = require('aws-sdk/clients/s3');
22
const core = require('@actions/core');
33
const fs = require('fs');
4+
const path = require('path');
45

56
try {
67
const endpoint = core.getInput('endpoint');
@@ -17,18 +18,12 @@ try {
1718
signatureVersion: 'v4',
1819
});
1920

20-
var uploadParams = { Bucket: bucket, Key: '', Body: '' };
21-
22-
var fileStream = fs.createReadStream(file);
23-
fileStream.on('error', function (err) {
24-
console.log('File Error', err);
25-
core.setFailed(err);
26-
});
27-
uploadParams.Body = fileStream;
28-
if (destination == "") {
29-
var path = require('path');
30-
uploadParams.Key = path.basename(file);
31-
} else { uploadParams.Key = destination; }
21+
const fileContent = fs.readFileSync(file);
22+
let uploadParams = {
23+
Bucket: bucket,
24+
Key: destination ? destination : path.basename(file),
25+
Body: fileContent
26+
};
3227

3328
// call S3 to retrieve upload file to specified bucket
3429
s3.upload(uploadParams, function (err, data) {

0 commit comments

Comments
 (0)