Skip to content

feat: stargate receiver#1

Merged
0xh3rman merged 24 commits intomainfrom
feat/stargate-receiver
Feb 6, 2025
Merged

feat: stargate receiver#1
0xh3rman merged 24 commits intomainfrom
feat/stargate-receiver

Conversation

@kuchmenko
Copy link
Copy Markdown
Contributor

@kuchmenko kuchmenko commented Jan 24, 2025

  • Implement starage receive lzCompose contract
  • Add multicalls handling
  • Deployment docs + .env.example

@gemcoder21 gemcoder21 requested a review from 0xh3rman January 24, 2025 17:50
Comment thread stargate/foundry.toml Outdated
Comment thread stargate/src/GemStargateMulticallHandler.sol Outdated
Comment thread stargate/src/GemStargateMulticallHandler.sol
@0xh3rman
Copy link
Copy Markdown
Collaborator

Things to improve:

  1. we can refactor the folder structure a little bit to share same forge-std submodule
  2. let's make multicall a separate Contract for reuse if possible, somthing like contract GemStargateReceiver is MulticallHandler, ILayerZeroComposer
  3. Add github action to do deployment

I will work on 3

@kuchmenko kuchmenko marked this pull request as ready for review January 27, 2025 15:55
Comment thread .env.example Outdated
Comment thread .env.example Outdated
Comment thread .env.example Outdated
Comment thread .env.example
Comment thread deploy/deploy-stargate.sh
@0xh3rman
Copy link
Copy Markdown
Collaborator

can you rename folder shared to library?

Comment thread src/shared/MulticallHandler.sol Outdated
Copy link
Copy Markdown
Collaborator

@0xh3rman 0xh3rman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the efforts to continue improving, I left some more comments, the ReentrancyGuard should be added back

Comment thread src/library/MulticallHandler.sol Outdated
Comment thread src/library/MulticallHandler.sol Outdated
Comment thread src/stargate/GemStargateMulticallHandler.sol Outdated
Comment thread deploy/deploy-stargate-non-zksync.sh
@0xh3rman 0xh3rman merged commit 800ba44 into main Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants