Skip to content

Conversation

@Leguark
Copy link
Member

@Leguark Leguark commented Sep 24, 2025

Fix PyKeops tensor operations and improve performance

This PR addresses several issues with tensor operations, particularly when using PyKeops:

  1. Add contiguous array check and conversion for PyKeops tensors
  2. Fix matrix multiplication in symbolic evaluator by correcting axis parameters
  3. Remove commented-out code in fancy_triangulation
  4. Add a comment about CUDA device check slowing down code
  5. Ensure tensors are contiguous before passing to LazyTensor

These changes improve the reliability of tensor operations across different backends and fix potential issues with non-contiguous arrays that could cause PyKeops to fail.

@Leguark Leguark changed the title [OPT] Making sure the vectors are contiguous [FIX] Fix PyKeops tensor operations and ensure contiguous arrays Sep 24, 2025
@Leguark Leguark marked this pull request as ready for review September 24, 2025 11:58
@Leguark Leguark force-pushed the torch_syntax branch 2 times, most recently from 77f8ab6 to 82f2653 Compare September 24, 2025 12:29
@Leguark Leguark changed the base branch from torch_syntax to graphite-base/22 September 24, 2025 12:31
@Leguark Leguark changed the base branch from graphite-base/22 to torch_syntax September 24, 2025 12:35
@Leguark Leguark changed the base branch from torch_syntax to graphite-base/22 September 24, 2025 12:41
@graphite-app graphite-app bot changed the base branch from graphite-base/22 to main September 24, 2025 12:42
Copy link
Member Author

Leguark commented Sep 24, 2025

Merge activity

  • Sep 24, 2:24 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Sep 24, 2:24 PM UTC: @Leguark merged this pull request with Graphite.

@Leguark Leguark merged commit f5cb64c into main Sep 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants