Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Task Names without Signatures #102

Open
0xm3rlin opened this issue Feb 11, 2023 · 1 comment
Open

Support Task Names without Signatures #102

0xm3rlin opened this issue Feb 11, 2023 · 1 comment

Comments

@0xm3rlin
Copy link

Instead of using signatures for task names consider the following:

Add a new parameter here:
https://github.com/gelatodigital/ops/blob/dd0d214bf59376ed771b5da036411f3cf6853081/contracts/Ops.sol#L50

string calldata name

And emit the name here:
https://github.com/gelatodigital/ops/blob/dd0d214bf59376ed771b5da036411f3cf6853081/contracts/Ops.sol#L206

then you can cheaply get all names for tasks, either by quickly querying events or by getting them through a subgraph

@hilmarx
Copy link
Contributor

hilmarx commented Feb 11, 2023

Thanks for the input @0xm3rlin, noted! Will work on a solution. Problem with this is that you would have to do an onchain tx if you want to change the name which I think is a bit annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants