Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the Open ID code to use Jersey client for all #4752

Open
at055612 opened this issue Jan 31, 2025 · 0 comments
Open

Change the Open ID code to use Jersey client for all #4752

at055612 opened this issue Jan 31, 2025 · 0 comments
Labels
enhancement A new feature or enhancement to an existing feature f:auth Authentication, authorisation, TLS, security, etc.
Milestone
v7.8

Comments

@at055612
Copy link
Member

Currently stroom.security.common.impl.ExternalIdpConfigurationProvider#fetchOpenIdConfigurationResponse is using the Apache Http Client, while the rest of the requests to the IDP (OpenIdPublicKeysSupplier and OpenIdTokenRequestHelper) are using the OPEN_ID named jersey client.

It would make sense to only have one set of client config for the OpenID interactions.
@at055612 at055612 added enhancement A new feature or enhancement to an existing feature f:auth Authentication, authorisation, TLS, security, etc. labels Jan 31, 2025
@at055612 at055612 added this to the 7.8 milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A new feature or enhancement to an existing feature f:auth Authentication, authorisation, TLS, security, etc.
Projects
None yet
Milestone
v7.8
Development

No branches or pull requests
1 participant
@at055612