fix return types of validation.success / validation.failure (#51)

Author: gcanti

CHANGELOG.md

@@ -12,6 +12,11 @@
 **Note**: Gaps between patch versions are faulty/broken releases.
 **Note**: A feature tagged as Experimental is in a high state of flux, you're at risk of it changing without notice.
 
+# 0.2.3
+
+- **Bug Fix**
+  - fix return types of `validation.success` / `validation.failure` (@gcanti)
+
 # 0.2.2
 
 - **Bug Fix**

package.json

@@ -1,6 +1,6 @@
 {
   "name": "fp-ts",
-  "version": "0.2.2",
+  "version": "0.2.3",
   "description": "Functional programming in TypeScript",
   "files": [
     "lib",

src/Validation.ts

@@ -226,11 +226,11 @@ export function isSuccess<L, A>(fa: Validation<L, A>): fa is Success<L, A> {
   return fa instanceof Success
 }
 
-export function failure<L, A>(semigroup: StaticSemigroup<L>, l: L): Failure<L, A> {
+export function failure<L, A>(semigroup: StaticSemigroup<L>, l: L): Validation<L, A> {
   return new Failure<L, A>(semigroup, l)
 }
 
-export function success<L, A>(a: A): Success<L, A> {
+export function success<L, A>(a: A): Validation<L, A> {
   return new Success<L, A>(a)
 }
 

test/Validation.ts

@@ -0,0 +1,39 @@
+import * as assert from 'assert'
+import * as array from '../src/Array'
+import * as validation from '../src/Validation'
+import { monoidString } from '../src/Monoid'
+import { sequence } from '../src/Traversable'
+
+describe('Validation', () => {
+
+  it('traverse', () => {
+    const success = [
+      validation.success<string, number>(1),
+      validation.success<string, number>(2),
+      validation.success<string, number>(3)
+    ]
+
+    const failure = [
+      validation.success<string, number>(1),
+      validation.failure<string, number>(monoidString, '[fail 1]'),
+      validation.failure<string, number>(monoidString, '[fail 2]')
+    ]
+
+    const x = sequence(validation.getApplicativeS(monoidString), array)(success)
+
+    if (validation.isSuccess(x)) {
+      assert.deepEqual(x.value, [1, 2, 3])
+    } else {
+      assert.ok(false)
+    }
+
+    const y = sequence(validation.getApplicativeS(monoidString), array)(failure)
+
+    if (validation.isFailure(y)) {
+      assert.strictEqual(y.value, '[fail 1][fail 2]')
+    } else {
+      assert.ok(false)
+    }
+  })
+
+})