Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing entries from demozoo #258

Closed
wants to merge 18 commits into from

Conversation

dag7dev
Copy link
Contributor

@dag7dev dag7dev commented Dec 18, 2024

What's been included:

  • old roms that didn't scraped very well
  • newer roms: since the script creation in 2021, newer productions have been added

The usual saulin is missing (it has been already removed in the past).

Copy link
Member

@avivace avivace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some referenced screenshots cannot be found? Could you try running the tests locally to see what breaks @dag7dev ?

"veitikka-ja-visionaari.png"
],
"slug": "veitikka-ja-visionaari",
"title": "Veitikka ja vision\u00e4\u00e4ri",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we have encoding issues here..

@avivace
Copy link
Member

avivace commented Dec 18, 2024

@dag7dev I've also updated the scraper to retain the original demozoo link and parse the release date (when it's complete (dd-mm-yyyy)

@dag7dev
Copy link
Contributor Author

dag7dev commented Dec 18, 2024

I believe we have encoding issues here..

is it an issue? they are these characters: ää

@dag7dev I've also updated the scraper to retain the original demozoo link and parse the release date (when it's complete (dd-mm-yyyy)

isnt better yyyy-mm-dd ?

@avivace
Copy link
Member

avivace commented Dec 18, 2024

I believe we have encoding issues here..

is it an issue? they are these characters: ää

@dag7dev I've also updated the scraper to retain the original demozoo link and parse the release date (when it's complete (dd-mm-yyyy)

isnt better yyyy-mm-dd ?

sorry yes that's the date that gets set. What I meant was that this happen when the full information is available (day, month year) in the "released" line in demozoo, but not when this is partial (e.g. "2009" or "august 2009" cases are not handled yet)

@dag7dev
Copy link
Contributor Author

dag7dev commented Dec 24, 2024

@avivace could we merge this and fix the importers later?

I plan to run them again as soon as I refactor everything, because everything needs to be tested.

@avivace
Copy link
Member

avivace commented Dec 24, 2024

The importer needs to be rerun to include the new modifications and this PR has to be updated accordingly. The link to the original release is very important and currently not included in the scraped entries

@avivace avivace force-pushed the missing-entries-from-demozoo branch from 4fec217 to cce32fc Compare December 25, 2024 00:12
@avivace
Copy link
Member

avivace commented Dec 25, 2024

Rebased against master

@avivace
Copy link
Member

avivace commented Dec 25, 2024

@dag7dev I've merged the new entries in 7c9dca0 and f003a0f, however, the scraper/this PR was not in the condition to be merged:

  • Encoding is broken. There are a number of game.json with unicode entities escaped and written in the title. Those still need to be fixed
  • There was no step checking for duplicates and comparing checksums against the ones we already have. This step flagged 1 duplicate entry
  • Your PR didn't include all the new entries that I see running the script now
  • Date parsing was missing. This is done. I worked on this and now we have dates, including imprecise ones (only year, year and month and full ones).
  • Screenshots are still missing. Only one is taken and we don't navigate to the page containing all of them. We need a script now that can add them back, potentially to the old scraped entries as well.
  • There are a number of duplicates which are not flagged by slug similarities and checksum collisions (20-y and pocket tangrams, from what I could see)
  • Upstream link was missing, so we were effectively losing the 'source' of those entries. I've added this and we should have a demozoo link as website now.

@avivace avivace closed this Dec 25, 2024
@avivace
Copy link
Member

avivace commented Dec 25, 2024

Also, .gbc files are saved as .gb, for some reason. Not sure if you fixed those manually when committing here or

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants