-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing entries from demozoo #258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some referenced screenshots cannot be found? Could you try running the tests locally to see what breaks @dag7dev ?
"veitikka-ja-visionaari.png" | ||
], | ||
"slug": "veitikka-ja-visionaari", | ||
"title": "Veitikka ja vision\u00e4\u00e4ri", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we have encoding issues here..
@dag7dev I've also updated the scraper to retain the original demozoo link and parse the release date (when it's complete (dd-mm-yyyy) |
is it an issue? they are these characters: ää
isnt better yyyy-mm-dd ? |
sorry yes that's the date that gets set. What I meant was that this happen when the full information is available (day, month year) in the "released" line in demozoo, but not when this is partial (e.g. "2009" or "august 2009" cases are not handled yet) |
@avivace could we merge this and fix the importers later? I plan to run them again as soon as I refactor everything, because everything needs to be tested. |
The importer needs to be rerun to include the new modifications and this PR has to be updated accordingly. The link to the original release is very important and currently not included in the scraped entries |
4fec217
to
cce32fc
Compare
Rebased against master |
@dag7dev I've merged the new entries in 7c9dca0 and f003a0f, however, the scraper/this PR was not in the condition to be merged:
|
Also, .gbc files are saved as .gb, for some reason. Not sure if you fixed those manually when committing here or |
What's been included:
The usual saulin is missing (it has been already removed in the past).