cleanup IntelliJ warnings in dialect package

Author: gavinking

hibernate-core/src/main/java/org/hibernate/dialect/CockroachDialect.java

@@ -61,7 +61,6 @@
 import org.hibernate.tool.schema.extract.spi.ColumnTypeInformation;
 import org.hibernate.type.JavaObjectType;
 import org.hibernate.type.descriptor.jdbc.JdbcType;
-import org.hibernate.type.descriptor.jdbc.JdbcTypeConstructor;
 import org.hibernate.type.descriptor.jdbc.ObjectNullAsBinaryTypeJdbcType;
 import org.hibernate.type.descriptor.jdbc.UUIDJdbcType;
 import org.hibernate.type.descriptor.jdbc.VarbinaryJdbcType;

hibernate-core/src/main/java/org/hibernate/dialect/CockroachDialectQueryHints.java

@@ -84,7 +84,7 @@ String addJoinHint(String query, JoinHint hint) {
 		StringBuilder buffer = new StringBuilder();
 		int start = 0;
 		while ( m.find() ) {
-			buffer.append( query.substring( start, m.start() ) );
+			buffer.append(query, start, m.start());
 
 			if ( m.group( 1 ) == null ) {
 				buffer.append( " inner" );

hibernate-core/src/main/java/org/hibernate/dialect/DB2SqlAstTranslator.java

@@ -28,7 +28,6 @@
 import org.hibernate.sql.ast.tree.expression.Expression;
 import org.hibernate.sql.ast.tree.expression.Literal;
 import org.hibernate.sql.ast.tree.expression.SqlTuple;
-import org.hibernate.sql.ast.tree.expression.Summarization;
 import org.hibernate.sql.ast.tree.from.NamedTableReference;
 import org.hibernate.sql.ast.tree.from.QueryPartTableReference;
 import org.hibernate.sql.ast.tree.from.TableGroup;
@@ -558,23 +557,6 @@ protected void renderSelectTupleComparison(
 		emulateSelectTupleComparison( lhsExpressions, tuple.getExpressions(), operator, true );
 	}
 
-	@Override
-	protected void renderPartitionItem(Expression expression) {
-		if ( expression instanceof Literal ) {
-			appendSql( "()" );
-		}
-		else if ( expression instanceof Summarization ) {
-			Summarization summarization = (Summarization) expression;
-			appendSql( summarization.getKind().sqlText() );
-			appendSql( OPEN_PARENTHESIS );
-			renderCommaSeparated( summarization.getGroupings() );
-			appendSql( CLOSE_PARENTHESIS );
-		}
-		else {
-			expression.accept( this );
-		}
-	}
-
 	@Override
 	protected boolean supportsRowValueConstructorSyntax() {
 		return false;

hibernate-core/src/main/java/org/hibernate/dialect/DB2StructJdbcType.java

@@ -31,7 +31,7 @@
  * To support UDTs, we require that a transform exists for the UDT that serializes from SQL to XML
  * and deserializes to SQL from UDT. This means that from the JDBC perspective, this is an XML type,
  * but the database models it internally as UDT.
- *
+ * <p>
  * The {@link org.hibernate.dialect.aggregate.DB2AggregateSupport} generates the functions and transforms for this
  * process automatically, but note that all of this is only used for functions and native queries.
  * By default, we select individual struct parts to avoid the encoding/decoding.

hibernate-core/src/main/java/org/hibernate/dialect/DB2iDialect.java

@@ -131,16 +131,6 @@ public boolean supportsSkipLocked() {
 		return true;
 	}
 
-	@Override
-	public boolean supportsLateral() {
-		return true;
-	}
-
-	@Override
-	public boolean supportsRecursiveCTE() {
-		return true;
-	}
-
 	@Override
 	public SqlAstTranslatorFactory getSqlAstTranslatorFactory() {
 		return new StandardSqlAstTranslatorFactory() {

hibernate-core/src/main/java/org/hibernate/dialect/DB2zDialect.java

@@ -143,16 +143,6 @@ public boolean supportsSkipLocked() {
 		return true;
 	}
 
-	@Override
-	public boolean supportsLateral() {
-		return true;
-	}
-
-	@Override
-	public boolean supportsRecursiveCTE() {
-		return true;
-	}
-
 	@Override
 	public String timestampaddPattern(TemporalUnit unit, TemporalType temporalType, IntervalType intervalType) {
 		final StringBuilder pattern = new StringBuilder();

hibernate-core/src/main/java/org/hibernate/dialect/DerbyDialect.java

@@ -407,7 +407,7 @@ protected <T extends JdbcOperation> SqlAstTranslator<T> buildTranslator(
 	 * no functions at all for calendaring, but we can
 	 * emulate the most basic functionality of extract()
 	 * using the functions it does have.
-	 *
+	 * <p>
 	 * The only supported {@link TemporalUnit}s are:
 	 * {@link TemporalUnit#YEAR},
 	 * {@link TemporalUnit#MONTH}
@@ -559,11 +559,6 @@ public boolean supportsCommentOn() {
 		return false;
 	}
 
-	@Override
-	public RowLockStrategy getWriteRowLockStrategy() {
-		return RowLockStrategy.NONE;
-	}
-
 	@Override
 	public RowLockStrategy getReadRowLockStrategy() {
 		return RowLockStrategy.NONE;

hibernate-core/src/main/java/org/hibernate/dialect/DerbySqlAstTranslator.java

@@ -183,11 +183,6 @@ protected void visitAnsiCaseSimpleExpression(
 		}
 	}
 
-	@Override
-	protected String getForUpdate() {
-		return " for update";
-	}
-
 	@Override
 	protected String getForShare(int timeoutMillis) {
 		return " for read only";

hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java

@@ -179,7 +179,6 @@
 import org.hibernate.type.descriptor.jdbc.ClobJdbcType;
 import org.hibernate.type.descriptor.jdbc.JdbcLiteralFormatter;
 import org.hibernate.type.descriptor.jdbc.JdbcType;
-import org.hibernate.type.descriptor.jdbc.JdbcTypeConstructor;
 import org.hibernate.type.descriptor.jdbc.LongNVarcharJdbcType;
 import org.hibernate.type.descriptor.jdbc.NCharJdbcType;
 import org.hibernate.type.descriptor.jdbc.NClobJdbcType;
@@ -1588,8 +1587,8 @@ private boolean sameColumnType(int typeCode1, int typeCode2) {
 	 * <p>
 	 * An implementation may set configuration properties from
 	 * {@link #initDefaultProperties()}, though it is discouraged.
-	 *
-	 * @return a set of Hibernate configuration properties
+	 the
+	 * @return the Hibernate configuration properties
 	 *
 	 * @see #initDefaultProperties()
 	 */
@@ -1778,9 +1777,7 @@ public Blob mergeBlob(Blob original, Blob target, SharedSessionContractImplement
 			}
 			final JdbcServices jdbcServices = session.getFactory().getFastSessionServices().jdbcServices;
 			try {
-				final LobCreator lobCreator = jdbcServices.getLobCreator(
-						session
-				);
+				final LobCreator lobCreator = jdbcServices.getLobCreator( session );
 				return original == null
 						? lobCreator.createBlob( ArrayHelper.EMPTY_BYTE_ARRAY )
 						: lobCreator.createBlob( original.getBinaryStream(), original.length() );
@@ -4575,7 +4572,7 @@ public String addSqlHintOrComment(
 		// Keep this here, rather than moving to Select.
 		// Some Dialects may need the hint to be appended to the very end or beginning
 		// of the finalized SQL statement, so wait until everything is processed.
-		if ( queryOptions.getDatabaseHints() != null && queryOptions.getDatabaseHints().size() > 0 ) {
+		if ( queryOptions.getDatabaseHints() != null && !queryOptions.getDatabaseHints().isEmpty() ) {
 			sql = getQueryHintString( sql, queryOptions.getDatabaseHints() );
 		}
 		if ( commentsEnabled && queryOptions.getComment() != null ) {

hibernate-core/src/main/java/org/hibernate/dialect/H2Dialect.java

@@ -63,7 +63,6 @@
 import org.hibernate.sql.exec.spi.JdbcOperation;
 import org.hibernate.sql.model.MutationOperation;
 import org.hibernate.sql.model.internal.OptionalTableUpdate;
-import org.hibernate.sql.model.jdbc.OptionalTableUpdateOperation;
 import org.hibernate.tool.schema.extract.internal.SequenceInformationExtractorLegacyImpl;
 import org.hibernate.tool.schema.extract.spi.SequenceInformationExtractor;
 import org.hibernate.type.descriptor.jdbc.H2FormatJsonJdbcType;
@@ -335,11 +334,11 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio
 	}
 
 	/**
-	 * H2 requires a very special emulation, because {@code unnest} is pretty much useless,
-	 * due to https://github.com/h2database/h2database/issues/1815.
-	 * This emulation uses {@code array_get}, {@code array_length} and {@code system_range} functions to roughly achieve the same,
-	 * but requires that {@code system_range} is fed with a "maximum array size".
-	 */
+     * H2 requires a very special emulation, because {@code unnest} is pretty much useless,
+     * due to <a href="https://github.com/h2database/h2database/issues/1815">issue 1815</a>.
+     * This emulation uses {@code array_get}, {@code array_length} and {@code system_range} functions to roughly achieve the same,
+     * but requires that {@code system_range} is fed with a "maximum array size".
+     */
 	protected int getMaximumArraySize() {
 		return 1000;
 	}
@@ -954,12 +953,12 @@ private static MutationOperation usingMerge(
 		return translator.createMergeOperation( optionalTableUpdate );
 	}
 
-	private static MutationOperation withoutMerge(
-			EntityMutationTarget mutationTarget,
-			OptionalTableUpdate optionalTableUpdate,
-			SessionFactoryImplementor factory) {
-		return new OptionalTableUpdateOperation( mutationTarget, optionalTableUpdate, factory );
-	}
+//	private static MutationOperation withoutMerge(
+//			EntityMutationTarget mutationTarget,
+//			OptionalTableUpdate optionalTableUpdate,
+//			SessionFactoryImplementor factory) {
+//		return new OptionalTableUpdateOperation( mutationTarget, optionalTableUpdate, factory );
+//	}
 
 	@Override
 	public ParameterMarkerStrategy getNativeParameterMarkerStrategy() {

hibernate-core/src/main/java/org/hibernate/dialect/H2SqlAstTranslator.java

@@ -17,7 +17,6 @@
 import org.hibernate.sql.ast.Clause;
 import org.hibernate.sql.ast.SqlAstNodeRenderingMode;
 import org.hibernate.sql.ast.spi.SqlSelection;
-import org.hibernate.sql.ast.tree.MutationStatement;
 import org.hibernate.sql.ast.tree.Statement;
 import org.hibernate.sql.ast.tree.cte.CteContainer;
 import org.hibernate.sql.ast.tree.cte.CteTableGroup;

hibernate-core/src/main/java/org/hibernate/dialect/HANASqlAstTranslator.java

@@ -8,20 +8,16 @@
 
 import java.util.List;
 
-import org.hibernate.LockMode;
 import org.hibernate.MappingException;
 import org.hibernate.engine.spi.SessionFactoryImplementor;
 import org.hibernate.internal.util.collections.Stack;
 import org.hibernate.query.IllegalQueryOperationException;
-import org.hibernate.query.sqm.BinaryArithmeticOperator;
 import org.hibernate.query.sqm.ComparisonOperator;
 import org.hibernate.sql.ast.Clause;
 import org.hibernate.sql.ast.SqlAstNodeRenderingMode;
 import org.hibernate.sql.ast.spi.AbstractSqlAstTranslator;
 import org.hibernate.sql.ast.tree.Statement;
 import org.hibernate.sql.ast.tree.cte.CteStatement;
-import org.hibernate.sql.ast.tree.delete.DeleteStatement;
-import org.hibernate.sql.ast.tree.expression.BinaryArithmeticExpression;
 import org.hibernate.sql.ast.tree.expression.Expression;
 import org.hibernate.sql.ast.tree.expression.Literal;
 import org.hibernate.sql.ast.tree.expression.Summarization;

hibernate-core/src/main/java/org/hibernate/dialect/HSQLDialect.java

@@ -369,11 +369,6 @@ public boolean supportsLockTimeouts() {
 		return false;
 	}
 
-	@Override
-	public String getForUpdateString() {
-		return " for update";
-	}
-
 	@Override
 	public LimitHandler getLimitHandler() {
 		return OffsetFetchLimitHandler.INSTANCE;

hibernate-core/src/main/java/org/hibernate/dialect/HSQLSqlAstTranslator.java

@@ -18,12 +18,10 @@
 import org.hibernate.sql.ast.SqlAstNodeRenderingMode;
 import org.hibernate.sql.ast.spi.AbstractSqlAstTranslator;
 import org.hibernate.sql.ast.spi.SqlSelection;
-import org.hibernate.sql.ast.tree.MutationStatement;
 import org.hibernate.sql.ast.tree.Statement;
 import org.hibernate.sql.ast.tree.expression.BinaryArithmeticExpression;
 import org.hibernate.sql.ast.tree.expression.CaseSearchedExpression;
 import org.hibernate.sql.ast.tree.expression.CaseSimpleExpression;
-import org.hibernate.sql.ast.tree.expression.ColumnReference;
 import org.hibernate.sql.ast.tree.expression.Expression;
 import org.hibernate.sql.ast.tree.expression.Literal;
 import org.hibernate.sql.ast.tree.expression.SqlTuple;

hibernate-core/src/main/java/org/hibernate/dialect/MariaDBDialect.java

@@ -185,11 +185,6 @@ public boolean doesRoundTemporalOnOverflow() {
 		return false;
 	}
 
-	@Override
-	protected MySQLStorageEngine getDefaultMySQLStorageEngine() {
-		return InnoDBStorageEngine.INSTANCE;
-	}
-
 	@Override
 	public boolean supportsIfExistsBeforeConstraintName() {
 		return true;

hibernate-core/src/main/java/org/hibernate/dialect/MariaDBSqlAstTranslator.java

@@ -228,11 +228,6 @@ protected boolean shouldEmulateFetchClause(QueryPart queryPart) {
 		return useOffsetFetchClause( queryPart ) && getQueryPartForRowNumbering() != queryPart && supportsWindowFunctions() && !isRowsOnlyFetchClauseType( queryPart );
 	}
 
-	@Override
-	protected boolean supportsSimpleQueryGrouping() {
-		return true;
-	}
-
 	@Override
 	protected boolean shouldEmulateLateralWithIntersect(QueryPart queryPart) {
 		// Intersect emulation requires nested correlation when no simple query grouping is possible

hibernate-core/src/main/java/org/hibernate/dialect/OracleArrayJdbcType.java

@@ -35,7 +35,6 @@
 
 import static java.sql.Types.ARRAY;
 import static java.util.Collections.emptySet;
-import static org.hibernate.internal.util.collections.ArrayHelper.EMPTY_STRING_ARRAY;
 
 /**
  * Descriptor for {@link Types#ARRAY ARRAY} handling.

hibernate-core/src/main/java/org/hibernate/dialect/OracleDialect.java

@@ -84,7 +84,6 @@
 import org.hibernate.type.descriptor.jdbc.AggregateJdbcType;
 import org.hibernate.type.descriptor.jdbc.BlobJdbcType;
 import org.hibernate.type.descriptor.jdbc.JdbcType;
-import org.hibernate.type.descriptor.jdbc.JdbcTypeConstructor;
 import org.hibernate.type.descriptor.jdbc.NullJdbcType;
 import org.hibernate.type.descriptor.jdbc.ObjectNullAsNullTypeJdbcType;
 import org.hibernate.type.descriptor.jdbc.OracleJsonBlobJdbcType;

hibernate-core/src/main/java/org/hibernate/dialect/OracleNestedTableJdbcType.java

@@ -35,7 +35,6 @@
 import static java.sql.Types.ARRAY;
 import static java.util.Collections.emptySet;
 import static org.hibernate.internal.util.StringHelper.truncate;
-import static org.hibernate.internal.util.collections.ArrayHelper.EMPTY_STRING_ARRAY;
 
 /**
  * Descriptor for {@link Types#ARRAY ARRAY} handling.
@@ -113,13 +112,13 @@ protected void doBindNull(CallableStatement st, String name, WrapperOptions opti
 
 			@Override
 			protected void doBind(PreparedStatement st, X value, int index, WrapperOptions options) throws SQLException {
-				st.setArray( index, getArray( value, containerJavaType, options ) );
+				st.setArray( index, getArray( value, options ) );
 			}
 
 			@Override
 			protected void doBind(CallableStatement st, X value, String name, WrapperOptions options)
 					throws SQLException {
-				final java.sql.Array arr = getArray( value, containerJavaType, options );
+				final java.sql.Array arr = getArray( value, options );
 				try {
 					st.setObject( name, arr, ARRAY );
 				}
@@ -128,7 +127,7 @@ protected void doBind(CallableStatement st, X value, String name, WrapperOptions
 				}
 			}
 
-			private java.sql.Array getArray(X value, BasicPluralJavaType<X> containerJavaType, WrapperOptions options)
+			private java.sql.Array getArray(X value, WrapperOptions options)
 					throws SQLException {
 				//noinspection unchecked
 				final Class<Object[]> arrayClass = (Class<Object[]>) Array.newInstance(

hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLCastingIntervalSecondJdbcType.java

@@ -12,7 +12,6 @@
 import java.sql.ResultSet;
 import java.sql.SQLException;
 
-import org.hibernate.engine.jdbc.spi.JdbcServices;
 import org.hibernate.engine.spi.SessionFactoryImplementor;
 import org.hibernate.metamodel.mapping.JdbcMappingContainer;
 import org.hibernate.sql.ast.SqlAstTranslator;
@@ -40,25 +39,17 @@ public class PostgreSQLCastingIntervalSecondJdbcType implements AdjustableJdbcTy
 
 	@Override
 	public JdbcType resolveIndicatedType(JdbcTypeIndicators indicators, JavaType<?> domainJtd) {
-		final int scale;
-		if ( indicators.getColumnScale() == JdbcTypeIndicators.NO_COLUMN_SCALE ) {
-			scale = domainJtd.getDefaultSqlScale(
-					indicators.getTypeConfiguration()
-							.getServiceRegistry()
-							.getService( JdbcServices.class )
-							.getDialect(),
-					this
-			);
-		}
-		else {
-			scale = indicators.getColumnScale();
-		}
+		final int scale = indicators.getColumnScale() == JdbcTypeIndicators.NO_COLUMN_SCALE
+				? domainJtd.getDefaultSqlScale( indicators.getDialect(), this )
+				: indicators.getColumnScale();
 		if ( scale > 6 ) {
 			// Since the maximum allowed scale on PostgreSQL is 6 (microsecond precision),
 			// we have to switch to the numeric type if the value is greater
 			return indicators.getTypeConfiguration().getJdbcTypeRegistry().getDescriptor( SqlTypes.NUMERIC );
 		}
-		return this;
+		else {
+			return this;
+		}
 	}
 
 	@Override

hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLDialect.java

@@ -82,7 +82,6 @@
 import org.hibernate.type.descriptor.jdbc.BlobJdbcType;
 import org.hibernate.type.descriptor.jdbc.ClobJdbcType;
 import org.hibernate.type.descriptor.jdbc.JdbcType;
-import org.hibernate.type.descriptor.jdbc.JdbcTypeConstructor;
 import org.hibernate.type.descriptor.jdbc.ObjectNullAsBinaryTypeJdbcType;
 import org.hibernate.type.descriptor.jdbc.XmlJdbcType;
 import org.hibernate.type.descriptor.jdbc.spi.JdbcTypeRegistry;

hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLUUIDJdbcType.java

@@ -9,7 +9,6 @@
 import java.sql.CallableStatement;
 import java.sql.PreparedStatement;
 import java.sql.SQLException;
-import java.sql.Types;
 import java.util.UUID;
 
 import org.hibernate.type.descriptor.ValueBinder;