fix: TxList bug (#245) (#246)

ltitanb · BrycePy · web-flow · commit 3c92b0b597ff · 2025-09-18T19:44:19.000+01:00
Co-authored-by: Suthiwat Umpornpaiboon &lt;91750004+BrycePy@users.noreply.github.com&gt;
diff --git a/based/crates/common/src/transaction/tx_list.rs b/based/crates/common/src/transaction/tx_list.rs
@@ -49,12 +49,12 @@ impl TxList {
         if self.txs.front().is_some_and(|t| t.nonce() > nonce) {
             return false;
         }
-        while let Some(t) = self.txs.pop_front() {
-            if t.nonce() == nonce {
-                f(t);
+        while let Some(tx) = self.txs.pop_front() {
+            if tx.nonce() > nonce {
+                self.txs.push_front(tx);
                 break;
             }
-            f(t);
+            f(tx);
         }
         self.is_empty()
     }

Original file line number	Diff line number	Diff line change
`@@ -49,12 +49,12 @@ impl TxList {`
`49`	`49`	`if self.txs.front().is_some_and(\|t\| t.nonce() > nonce) {`
`50`	`50`	`return false;`
`51`	`51`	`}`
`52`		`- while let Some(t) = self.txs.pop_front() {`
`53`		`- if t.nonce() == nonce {`
`54`		`- f(t);`
	`52`	`+ while let Some(tx) = self.txs.pop_front() {`
	`53`	`+ if tx.nonce() > nonce {`
	`54`	`+ self.txs.push_front(tx);`
`55`	`55`	`break;`
`56`	`56`	`}`
`57`		`- f(t);`
	`57`	`+ f(tx);`
`58`	`58`	`}`
`59`	`59`	`self.is_empty()`
`60`	`60`	`}`