Skip to content

Commit 21be3e9

Browse files
committed
fix(ralphex-fe): drop dead ralphex_version bump from update workflow
The Dockerfile no longer pins ARG RALPHEX_VERSION (ralphex is pulled from GitHub "latest" at build time), so the workflow's grep for it returned empty and failed the extract step (exit 1) on every dispatch. - Remove the ralphex_version input, output, env, sed, and grep. - Realign the version-tag to bun<v>-hugo<v>, matching build-ralphex-fe.yml. - Keep the still-valid Bun/Hugo manual version-bump path intact.
1 parent 9b1bf05 commit 21be3e9

1 file changed

Lines changed: 3 additions & 18 deletions

File tree

‎.github/workflows/update-and-build-ralphex-fe.yml‎

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,6 @@ on:
1111
description: 'New Hugo version (e.g., 0.155.3). Leave empty to keep current.'
1212
required: false
1313
type: string
14-
ralphex_version:
15-
description: 'Ralphex version / Docker image tag (e.g., 0.11.0). Leave empty to keep current.'
16-
required: false
17-
type: string
1814
update_only:
1915
description: 'Only update Dockerfile without building image'
2016
required: false
@@ -39,7 +35,6 @@ jobs:
3935
versions_updated: ${{ steps.update.outputs.updated }}
4036
bun_version: ${{ steps.update.outputs.bun_version }}
4137
hugo_version: ${{ steps.update.outputs.hugo_version }}
42-
ralphex_version: ${{ steps.update.outputs.ralphex_version }}
4338

4439
steps:
4540
- name: Checkout repository
@@ -52,49 +47,41 @@ jobs:
5247
env:
5348
INPUT_BUN_VERSION: ${{ inputs.bun_version }}
5449
INPUT_HUGO_VERSION: ${{ inputs.hugo_version }}
55-
INPUT_RALPHEX_VERSION: ${{ inputs.ralphex_version }}
5650
run: |
5751
# Read current versions
5852
CURRENT_BUN=$(grep '^ARG BUN_VERSION=' "${{ env.DOCKERFILE_PATH }}" | cut -d'=' -f2)
5953
CURRENT_HUGO=$(grep '^ARG HUGO_VERSION=' "${{ env.DOCKERFILE_PATH }}" | cut -d'=' -f2)
60-
CURRENT_RALPHEX=$(grep '^ARG RALPHEX_VERSION=' "${{ env.DOCKERFILE_PATH }}" | cut -d'=' -f2)
6154
62-
if [ -z "$CURRENT_BUN" ] || [ -z "$CURRENT_HUGO" ] || [ -z "$CURRENT_RALPHEX" ]; then
55+
if [ -z "$CURRENT_BUN" ] || [ -z "$CURRENT_HUGO" ]; then
6356
echo "Error: Failed to extract current version(s) from Dockerfile"
6457
echo " Bun: ${CURRENT_BUN:-<empty>}"
6558
echo " Hugo: ${CURRENT_HUGO:-<empty>}"
66-
echo " Ralphex: ${CURRENT_RALPHEX:-<empty>}"
6759
exit 1
6860
fi
6961
7062
echo "Current versions:"
7163
echo " Bun: $CURRENT_BUN"
7264
echo " Hugo: $CURRENT_HUGO"
73-
echo " Ralphex: $CURRENT_RALPHEX"
7465
7566
# Use input values or fall back to current Dockerfile values
7667
NEW_BUN=${INPUT_BUN_VERSION:-$CURRENT_BUN}
7768
NEW_HUGO=${INPUT_HUGO_VERSION:-$CURRENT_HUGO}
78-
NEW_RALPHEX=${INPUT_RALPHEX_VERSION:-$CURRENT_RALPHEX}
7969
8070
echo ""
8171
echo "Target versions:"
8272
echo " Bun: $NEW_BUN"
8373
echo " Hugo: $NEW_HUGO"
84-
echo " Ralphex: $NEW_RALPHEX"
8574
8675
# Update versions in Dockerfile (GNU sed syntax for Linux)
8776
# Use | as delimiter to avoid breakage if version strings contain /
8877
sed -i "s|^ARG BUN_VERSION=.*|ARG BUN_VERSION=$NEW_BUN|" "${{ env.DOCKERFILE_PATH }}"
8978
sed -i "s|^ARG HUGO_VERSION=.*|ARG HUGO_VERSION=$NEW_HUGO|" "${{ env.DOCKERFILE_PATH }}"
90-
sed -i "s|^ARG RALPHEX_VERSION=.*|ARG RALPHEX_VERSION=$NEW_RALPHEX|" "${{ env.DOCKERFILE_PATH }}"
9179
9280
# Verify changes
9381
echo ""
9482
echo "Updated versions in Dockerfile:"
9583
grep '^ARG BUN_VERSION=' "${{ env.DOCKERFILE_PATH }}"
9684
grep '^ARG HUGO_VERSION=' "${{ env.DOCKERFILE_PATH }}"
97-
grep '^ARG RALPHEX_VERSION=' "${{ env.DOCKERFILE_PATH }}"
9885
9986
# Check if anything changed
10087
if git diff --quiet "${{ env.DOCKERFILE_PATH }}"; then
@@ -108,15 +95,13 @@ jobs:
10895
{
10996
echo "bun_version=$NEW_BUN"
11097
echo "hugo_version=$NEW_HUGO"
111-
echo "ralphex_version=$NEW_RALPHEX"
11298
} >> "$GITHUB_OUTPUT"
11399
114100
- name: Commit and push changes
115101
if: steps.update.outputs.updated == 'true'
116102
env:
117103
BUN_VERSION: ${{ steps.update.outputs.bun_version }}
118104
HUGO_VERSION: ${{ steps.update.outputs.hugo_version }}
119-
RALPHEX_VERSION: ${{ steps.update.outputs.ralphex_version }}
120105
GITHUB_ACTOR: ${{ github.actor }}
121106
ACTOR_ID: ${{ github.actor_id }}
122107
run: |
@@ -127,7 +112,7 @@ jobs:
127112
128113
# [skip ci] prevents build-ralphex-fe.yml from triggering a duplicate build
129114
git commit \
130-
-m "chore(ralphex-fe): update versions to Bun ${BUN_VERSION}, Hugo ${HUGO_VERSION}, Ralphex ${RALPHEX_VERSION} [skip ci]" \
115+
-m "chore(ralphex-fe): update versions to Bun ${BUN_VERSION}, Hugo ${HUGO_VERSION} [skip ci]" \
131116
-m "Updated via GitHub Actions workflow dispatch." \
132117
-m "Co-Authored-By: ${GITHUB_ACTOR} <${ACTOR_ID}+${GITHUB_ACTOR}@users.noreply.github.com>"
133118
@@ -152,7 +137,7 @@ jobs:
152137
image-name: devcontainers/ralphex-fe
153138
context: ralphex-fe
154139
dockerfile: ralphex-fe/Dockerfile
155-
version-tag: bun${{ needs.update-dockerfile.outputs.bun_version }}-hugo${{ needs.update-dockerfile.outputs.hugo_version }}-ralphex${{ needs.update-dockerfile.outputs.ralphex_version }}
140+
version-tag: bun${{ needs.update-dockerfile.outputs.bun_version }}-hugo${{ needs.update-dockerfile.outputs.hugo_version }}
156141
verify-command: 'bun --version && hugo version'
157142
extra-verify-script: |
158143
chromium --no-sandbox --version && \

0 commit comments

Comments
 (0)