Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: track server code coverage #41

Merged
merged 1 commit into from
Dec 10, 2022
Merged

CI: track server code coverage #41

merged 1 commit into from
Dec 10, 2022

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Nov 5, 2022 •
edited
Loading

Resolve #35

@codecov
Copy link

codecov bot commented Nov 5, 2022 •
edited
Loading

Codecov Report

Merging #41 (2a131aa) into master (2257148) will increase coverage by 31.40%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master      #41       +/-   ##
===========================================
+ Coverage   25.87%   57.27%   +31.40%     
===========================================
  Files          20       23        +3     
  Lines        2153     2675      +522     
===========================================
+ Hits          557     1532      +975     
+ Misses       1596     1143      -453
Impacted Files Coverage Δ
example/myserver.g 74.78% <100.00%> (ø)
example/karatsuba.g 61.75% <0.00%> (ø)
example/id512.g 62.50% <0.00%> (ø)
lib/webservice.g 62.90% <0.00%> (+4.83%) ⬆️
lib/openmath.g 56.80% <0.00%> (+14.89%) ⬆️
lib/utils.g 58.00% <0.00%> (+24.00%) ⬆️
lib/remote.gi 76.00% <0.00%> (+28.00%) ⬆️
lib/connect.gi 76.47% <0.00%> (+29.41%) ⬆️
lib/xstream.gi 64.70% <0.00%> (+40.58%) ⬆️
... and 4 more

@fingolfin fingolfin changed the title CI: track server code coverage (WIP, not yet done, please ignore) CI: track server code coverage Nov 5, 2022
@fingolfin fingolfin marked this pull request as ready for review November 5, 2022 01:28
@fingolfin fingolfin force-pushed the mh/ci branch 2 times, most recently from 67d8e15 to b309f03 Compare November 5, 2022 01:41
@fingolfin fingolfin mentioned this pull request Nov 5, 2022
Open
@fingolfin
Copy link
Member Author

@alex-konovalov OK to merge?

@olexandr-konovalov olexandr-konovalov merged commit 931139a into master Dec 10, 2022
@olexandr-konovalov olexandr-konovalov deleted the mh/ci branch December 10, 2022 13:56
@olexandr-konovalov
Copy link
Member

@fingolfin thanks. I'm looking at why ANUPQ doesn't build in GAP 4.10 - since it works with GAP 4.10 in https://github.com/gap-packages/anupq

@fingolfin
Copy link
Member Author

The GAP 4.10 tests run with the version of anupq bundled with GAP 4.10 . The tests in the anupq repository run with the latest anupq development version...

Moreover ubuntu-latest at GitHub recently was upgraded to a newer version, and so a newer GCC and libraries etc. This explains why it worked here before and now doesn't.

@olexandr-konovalov
Copy link
Member

Ok, that's fixed in #44. However, still no server coverage - reopened #35

@fingolfin fingolfin mentioned this pull request Dec 10, 2022
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olexandr-konovalov olexandr-konovalov olexandr-konovalov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CI to build manual and add coverage for the server code
2 participants
@fingolfin @olexandr-konovalov