-
Notifications
You must be signed in to change notification settings - Fork 483
Bump version to ena webin cli v9.0.1 + scaffold and chromosome level assembly support #7243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bgruening Sorry to bother you with this one... But for some reason my tests are succeeding, yet combining the test results fail :/ |
|
@bgruening now i did fix the tests locally, but it is still failing :( and I can't figure out what the problem is. Also in de CI the tests succeed |
|
@bedroesb Have restarted the CI for the failing step. Should turn green now. |
|
Thank you so much! I will continue on the new features and communicate when it is ready for merging. |
|
@bgruening and @SaimMomin12 The new features are implemented, and the tests in general are improved + newly added/new test data. The only problem: https://github.com/galaxyproject/tools-iuc/actions/runs/18205351104 my tests succeeded. I didn't change anything to the code besides taking away a datatype that was not allowed and now they all fail, every time due to another reason? If this one is merged: #7212 can be closed |
|
Locally they work fine ... |
|
Ok they passed again 🎉 @SaimMomin12 I don't know if you could work your magic again? |
|
That did the trick again. If there are any other blockers, let me know. |
Co-authored-by: Björn Grüning <[email protected]>
Co-authored-by: Björn Grüning <[email protected]>
Co-authored-by: Björn Grüning <[email protected]>
|
@bgruening Tools have passed! |
|
Also passed locally with these latest changes 👍 |
|
Thanks a lot! |
|
Attention: deployment skipped! https://github.com/galaxyproject/tools-iuc/actions/runs/18243342556 |
|
@mvdbeek any idea why the tool tests succeed, but combining the test results error? |
|
https://github.com/galaxyproject/tools-iuc/actions/runs/18243342556 indeed I notice that also the tool did not get pushed! |
|
Again the same story, tests and linting succeed, but combining the test results break. Is there something I can do? :/ |
|
@bgruening would the fix be as simple as rerunning the failed step in the CI of main? |
|
Mh, it was not deployed? thats what you mean? I triggered a rerun, hope its not in the TS. |
|
@bgruening thanks for the little push it needed! Now I can test it in real life! |
FOR CONTRIBUTOR:
To Do: