Skip to content

Conversation

@bedroesb
Copy link
Contributor

@bedroesb bedroesb commented Aug 26, 2025

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

To Do:

  • Add Form fields for agp and chromosome list files
  • Add test files for agp and chromosome list files
  • Write new test for chromosome level submissions

@bedroesb
Copy link
Contributor Author

@bgruening Sorry to bother you with this one... But for some reason my tests are succeeding, yet combining the test results fail :/

@bedroesb bedroesb changed the title Bump version to latest ena webin cli Bump version to ena webin cli v9.0.1 + scaffold and chromosome level assembly support Sep 22, 2025
@bedroesb
Copy link
Contributor Author

bedroesb commented Oct 1, 2025

@bgruening now i did fix the tests locally, but it is still failing :( and I can't figure out what the problem is. Also in de CI the tests succeed

@SaimMomin12
Copy link
Contributor

@bedroesb Have restarted the CI for the failing step. Should turn green now.

@bedroesb
Copy link
Contributor Author

bedroesb commented Oct 1, 2025

Thank you so much! I will continue on the new features and communicate when it is ready for merging.

@bedroesb
Copy link
Contributor Author

bedroesb commented Oct 2, 2025

@bgruening and @SaimMomin12 The new features are implemented, and the tests in general are improved + newly added/new test data. The only problem: https://github.com/galaxyproject/tools-iuc/actions/runs/18205351104 my tests succeeded. I didn't change anything to the code besides taking away a datatype that was not allowed and now they all fail, every time due to another reason?

If this one is merged: #7212 can be closed

@bedroesb
Copy link
Contributor Author

bedroesb commented Oct 2, 2025

Locally they work fine ...

@bedroesb
Copy link
Contributor Author

bedroesb commented Oct 2, 2025

Ok they passed again 🎉 @SaimMomin12 I don't know if you could work your magic again?

@bedroesb
Copy link
Contributor Author

bedroesb commented Oct 3, 2025

That did the trick again. If there are any other blockers, let me know.

@bedroesb
Copy link
Contributor Author

bedroesb commented Oct 3, 2025

@bgruening Tools have passed!

@bedroesb
Copy link
Contributor Author

bedroesb commented Oct 3, 2025

Also passed locally with these latest changes 👍

@bgruening bgruening merged commit abb1519 into galaxyproject:main Oct 4, 2025
27 of 31 checks passed
@bgruening
Copy link
Member

Thanks a lot!

@mvdbeek
Copy link
Member

mvdbeek commented Oct 4, 2025

Attention: deployment skipped!

https://github.com/galaxyproject/tools-iuc/actions/runs/18243342556

@bedroesb
Copy link
Contributor Author

bedroesb commented Oct 4, 2025

@mvdbeek any idea why the tool tests succeed, but combining the test results error?

@bedroesb
Copy link
Contributor Author

bedroesb commented Oct 6, 2025

https://github.com/galaxyproject/tools-iuc/actions/runs/18243342556 indeed I notice that also the tool did not get pushed!

@bedroesb
Copy link
Contributor Author

bedroesb commented Oct 6, 2025

Again the same story, tests and linting succeed, but combining the test results break. Is there something I can do? :/

@B0r1sD B0r1sD mentioned this pull request Oct 6, 2025
5 tasks
@bedroesb
Copy link
Contributor Author

bedroesb commented Oct 6, 2025

@bgruening would the fix be as simple as rerunning the failed step in the CI of main?

@bgruening
Copy link
Member

Mh, it was not deployed? thats what you mean? I triggered a rerun, hope its not in the TS.

@bedroesb
Copy link
Contributor Author

bedroesb commented Oct 6, 2025

@bgruening thanks for the little push it needed! Now I can test it in real life!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants